On 6 September 2018 at 18:53, Laszlo Ersek <[email protected]> wrote: > On 09/06/18 15:45, Ard Biesheuvel wrote: >> Now that Itanium support has been dropped, we can remove the various >> occurrences of the ELILO on Itanium PE/COFF header workaround. >> >> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <[email protected]> >> --- >> >> EdkCompatibilityPkg/Foundation/Library/EdkIIGlueLib/Library/BasePeCoffLib/BasePeCoff.c >> | 60 +++----------------- >> 1 file changed, 8 insertions(+), 52 deletions(-) > > Should we care about EdkCompatibilityPkg at all? Because: > > * IPF removal seems not to have occurred to EdkCompatibilityPkg: > > $ git grep -w IPF -- 'EdkCompatibilityPkg/*inf' > [bunch of hits] > > * In <https://bugzilla.tianocore.org/show_bug.cgi?id=816#c7>, you wrote: > >> [...] there is a big difference between IPF drivers that are never >> referenced by modern platforms, and workarounds in generic code that >> are present in every modern build for every platform, and are only >> intended for a specific build of ELILO. > >> The former is essentially dead code. The latter gets executed many >> times on every boot of every modern UEFI platform in existence. > > Under that distinction, I would classify EdkCompatibilityPkg as the > first category, i.e., essentially dead code. >
OK, fair enough. I don't care about EdkCompatibilityPkg at all, I just wanted to be thorough, but if others don't care either, I'll drop this from v2. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
