On 6 September 2018 at 20:55, Vladimir Olovyannikov <[email protected]> wrote: > The only valid memory types for DmaAlignedBuffer should be > EfiBootServicesData and EfiRuntimeServicesData. However due to the typo, > there is no way to allocate runtime pages, and INVALID_PARAMETER is > always returned. Fix the typo. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vladimir Olovyannikov <[email protected]>
Patches #1 and #2 Reviewed-by: Ard Biesheuvel <[email protected]> Pushed as 4d621893471c..c4709260f62f Thanks! > --- > EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > index 564db83c901c..8ca9e6aa5b1b 100644 > --- a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > +++ b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > @@ -154,7 +154,7 @@ DmaAllocateAlignedBuffer ( > // > if (MemoryType == EfiBootServicesData) { > *HostAddress = AllocateAlignedPages (Pages, Alignment); > - } else if (MemoryType != EfiRuntimeServicesData) { > + } else if (MemoryType == EfiRuntimeServicesData) { > *HostAddress = AllocateAlignedRuntimePages (Pages, Alignment); > } else { > return EFI_INVALID_PARAMETER; > -- > 2.18.0 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
