Reviewed-by: Hao Wu <[email protected]> Best Regards, Hao Wu
From: Wang, Jian J Sent: Saturday, September 08, 2018 11:32 AM To: edk2-devel; [email protected] Cc: Wu, Hao A Subject: RE: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation And BZ#1164: https://bugzilla.tianocore.org/show_bug.cgi?id=1164 Regards, Jian From: edk2-devel [mailto:[email protected]] Sent: Saturday, September 08, 2018 11:25 AM To: edk2-devel <[email protected]>; [email protected] Cc: Wu, Hao A <[email protected]> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation Forgot to mention BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=1095 Regards, Jian > -----Original Message----- > From: edk2-devel [mailto:[email protected]] > Sent: Saturday, September 08, 2018 10:48 AM > To: [email protected]<mailto:[email protected]> > Cc: Wu, Hao A <[email protected]<mailto:[email protected]>> > Subject: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation > > The left operand is 64-bit but right operand could be 32-bit. > A typecast is a must because of '~' op before it. > > Cc: Hao A Wu <[email protected]<mailto:[email protected]>> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > <[email protected]<mailto:[email protected]>> > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index ef6e080a07..0a980b9753 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -1181,7 +1181,7 @@ DebugExceptionHandler ( > > for (PFEntry = 0; PFEntry < mPFEntryCount[CpuIndex]; PFEntry++) { > if (mLastPFEntryPointer[CpuIndex][PFEntry] != NULL) { > - *mLastPFEntryPointer[CpuIndex][PFEntry] &= ~IA32_PG_P; > + *mLastPFEntryPointer[CpuIndex][PFEntry] &= ~(UINT64)IA32_PG_P; > } > } > > -- > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected]<mailto:[email protected]> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected]<mailto:[email protected]> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
