Hi Jian, After update with Laszlo's comments, This serial Reviewed-by: Eric Dong <eric.d...@intel.com>
Thanks, Eric > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Friday, September 14, 2018 3:12 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: add > message for S3 config error > > > v2 > > a. refine the error message to be more useful > > b. improve the code logic > > BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165 > > HOB gEfiAcpiVariableGuid is a must have data for S3 resume if > PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't embody this > strong binding between them. This patch series try to fix this problem by a > useful message. > > Jian J Wang (2): > UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error > UefiCpuPkg/PiSmmCpuDxeSmm: move InitSmmS3Cr3() into else block > > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > -- > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel