On 09/18/18 11:04, Jian J Wang wrote: >> v2 changes: >> Incorpate Laszlo's reivew comments >> a. change title >> b. drop unrelated changes >> c. remove error message > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1166 > > Visual Studio 2012 will complain uninitialized variable, StackBase, > in the CpuPaging.c. This patch adds code to init it to zero and > ASSERT check against 0. This is enough since uninit case will only > happen during retrieving stack memory via gEfiHobMemoryAllocStackGuid. > But this HOB will always be created in advance. > > Cc: Dandan Bi <[email protected]> > Cc: Hao A Wu <[email protected]> > Cc: Eric Dong <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <[email protected]> > --- > UefiCpuPkg/CpuMpPei/CpuPaging.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/UefiCpuPkg/CpuMpPei/CpuPaging.c b/UefiCpuPkg/CpuMpPei/CpuPaging.c > index bcb942a8e5..c7e0822452 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuPaging.c > +++ b/UefiCpuPkg/CpuMpPei/CpuPaging.c > @@ -554,6 +554,8 @@ SetupStackGuardPage ( > MpInitLibGetNumberOfProcessors(&NumberOfProcessors, NULL); > MpInitLibWhoAmI (&Bsp); > for (Index = 0; Index < NumberOfProcessors; ++Index) { > + StackBase = 0; > + > if (Index == Bsp) { > Hob.Raw = GetHobList (); > while ((Hob.Raw = GetNextHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, > Hob.Raw)) != NULL) { > @@ -570,6 +572,7 @@ SetupStackGuardPage ( > // > MpInitLibStartupThisAP(GetStackBase, Index, NULL, 0, (VOID > *)&StackBase, NULL); > } > + ASSERT (StackBase != 0); > // > // Set Guard page at stack base address. > // >
Reviewed-by: Laszlo Ersek <[email protected]> Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
