Reviewed-by: [email protected]
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Star Zeng > Sent: Wednesday, September 19, 2018 10:38 AM > To: [email protected] > Cc: Kinney, Michael D <[email protected]>; Younas khan > <[email protected]>; Yao, Jiewen <[email protected]>; > Gao, Liming <[email protected]>; Zeng, Star <[email protected]> > Subject: [edk2] [PATCH] IntelFrameworkPkg FrameworkUefiLib: Add new > EfiLocateXXXAcpiTable APIs > > It updates FrameworkUefiLib and is the supplement to > https://lists.01.org/pipermail/edk2-devel/2018-September/029757.html > > https://bugzilla.tianocore.org/show_bug.cgi?id=967 > Request to add a library function for GetAcpiTable() in order > to get ACPI table using signature as input. > > After evaluation, we found there are many duplicated code to > find ACPI table by signature in different modules. > > This patch adds new EfiLocateXXXAcpiTable() APIs in UefiLib > for the request and also the following patch to remove the > duplicated code. > > V2: > ASSERT(FALSE) and return NULL instead of real implementation for the > new APIs as the IntelFrameworkPkg is a to-be-deprecated packages. > > Cc: Younas khan <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Jiewen Yao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng <[email protected]> > Reviewed-by: Liming Gao <[email protected]> > --- > IntelFrameworkPkg/Library/FrameworkUefiLib/Acpi.c | 88 > ++++++++++++++++++++++ > .../Library/FrameworkUefiLib/FrameworkUefiLib.inf | 1 + > 2 files changed, 89 insertions(+) > create mode 100644 IntelFrameworkPkg/Library/FrameworkUefiLib/Acpi.c > > diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/Acpi.c > b/IntelFrameworkPkg/Library/FrameworkUefiLib/Acpi.c > new file mode 100644 > index 000000000000..4b41abd036f9 > --- /dev/null > +++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/Acpi.c > @@ -0,0 +1,88 @@ > +/** @file > + This module provides help function for finding ACPI table. > + > + Copyright (c) 2018, Intel Corporation. All rights reserved.<BR> > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the > BSD License > + which accompanies this distribution. The full text of the license may be > found at > + http://opensource.org/licenses/bsd-license.php. > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#include "UefiLibInternal.h" > +#include <IndustryStandard/Acpi.h> > + > +/** > + This function locates next ACPI table in XSDT/RSDT based on Signature > and > + previous returned Table. > + > + If PreviousTable is NULL: > + This function will locate the first ACPI table in XSDT/RSDT based on > + Signature in gEfiAcpi20TableGuid system configuration table first, and > then > + gEfiAcpi10TableGuid system configuration table. > + This function will locate in XSDT first, and then RSDT. > + For DSDT, this function will locate XDsdt in FADT first, and then Dsdt in > + FADT. > + For FACS, this function will locate XFirmwareCtrl in FADT first, and then > + FirmwareCtrl in FADT. > + > + If PreviousTable is not NULL: > + 1. If it could be located in XSDT in gEfiAcpi20TableGuid system > configuration > + table, then this function will just locate next table in XSDT in > + gEfiAcpi20TableGuid system configuration table. > + 2. If it could be located in RSDT in gEfiAcpi20TableGuid system > configuration > + table, then this function will just locate next table in RSDT in > + gEfiAcpi20TableGuid system configuration table. > + 3. If it could be located in RSDT in gEfiAcpi10TableGuid system > configuration > + table, then this function will just locate next table in RSDT in > + gEfiAcpi10TableGuid system configuration table. > + > + It's not supported that PreviousTable is not NULL but > PreviousTable->Signature > + is not same with Signature, NULL will be returned. > + > + @param Signature ACPI table signature. > + @param PreviousTable Pointer to previous returned table to > locate next > + table, or NULL to locate first table. > + > + @return Next ACPI table or NULL if not found. > + > +**/ > +EFI_ACPI_COMMON_HEADER * > +EFIAPI > +EfiLocateNextAcpiTable ( > + IN UINT32 Signature, > + IN EFI_ACPI_COMMON_HEADER *PreviousTable OPTIONAL > + ) > +{ > + ASSERT (FALSE); > + return NULL; > +} > + > +/** > + This function locates first ACPI table in XSDT/RSDT based on Signature. > + > + This function will locate the first ACPI table in XSDT/RSDT based on > + Signature in gEfiAcpi20TableGuid system configuration table first, and > then > + gEfiAcpi10TableGuid system configuration table. > + This function will locate in XSDT first, and then RSDT. > + For DSDT, this function will locate XDsdt in FADT first, and then Dsdt in > + FADT. > + For FACS, this function will locate XFirmwareCtrl in FADT first, and then > + FirmwareCtrl in FADT. > + > + @param Signature ACPI table signature. > + > + @return First ACPI table or NULL if not found. > + > +**/ > +EFI_ACPI_COMMON_HEADER * > +EFIAPI > +EfiLocateFirstAcpiTable ( > + IN UINT32 Signature > + ) > +{ > + return EfiLocateNextAcpiTable (Signature, NULL); > +} > diff --git > a/IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > b/IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > index 182d20fca051..086d898ee7dc 100644 > --- a/IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > +++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > @@ -37,6 +37,7 @@ [Sources] > Console.c > UefiLib.c > UefiLibInternal.h > + Acpi.c > > [Packages] > MdePkg/MdePkg.dec > -- > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
