I agree to delete it! We have git history which can tell us how to re-add them in future.:)
> -----Original Message----- > From: Carsey, Jaben > Sent: Tuesday, September 25, 2018 10:51 PM > To: Tomas Pilar (tpilar) <[email protected]>; [email protected]; Ni, > Ruiyu <[email protected]> > Subject: RE: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as > unused > > I would prefer we just delete this. > > Ray, > What do you think? > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Tomas Pilar (tpilar) > > Sent: Tuesday, September 25, 2018 3:15 AM > > To: [email protected] > > Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c > > as unused > > Importance: High > > > > This fixes unused const variable gcc 7.3 compilation error. Array is > > not simply removed as the list of invalid characters might be salient > > in future and for easy documentation. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Tomas Pilar <[email protected]> > > --- > > ShellPkg/Application/Shell/Shell.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Application/Shell/Shell.c > > b/ShellPkg/Application/Shell/Shell.c > > index 397cfd1994..38b002a144 100644 > > --- a/ShellPkg/Application/Shell/Shell.c > > +++ b/ShellPkg/Application/Shell/Shell.c > > @@ -2751,7 +2751,7 @@ RunCommand( > > } > > > > > > -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', > > L'/', L'\"', 0x0001, 0x0002}; > > +STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) = {L'*', > > +L'?', > > L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002}; > > > > /** > > Function to process a NSH script file via SHELL_FILE_HANDLE. > > -- > > 2.17.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
