Hi Patrick Do you agree that we only need merge 2/3 and discard 1/3 and 3/3?
I will push 2/3 after get your confirmation. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Desimone, Nathaniel L > Sent: Thursday, September 20, 2018 12:38 PM > To: Patrick Georgi <[email protected]> > Cc: [email protected] > Subject: Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format > SplitFspBin.py > with native newlines > > Hi Patrick, > > > If the autoconversion is not considered good enough, I'd propose keeping > out patch 1 of this series that adds the #! line and the executable bit, and > instead expect people to always call the script with "python > $path/SplitFspBin.py" to keep confusion at a minimum. > > There was quite a debate on this a few years ago. Without getting into the > details, the decision was made that people on Windows platforms would set > core.autocrlf=false and that source code would be stored in CR-LF format. > Per your recommendation, it sounds like we should only merge patch 2 then. > > Thanks, > Nate > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
