Good news. -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Ard Biesheuvel Sent: Wednesday, September 26, 2018 4:01 PM To: Zeng, Star <[email protected]> Cc: Ni, Ruiyu <[email protected]>; Tian, Feng <[email protected]>; Wang, Fei1 <[email protected]>; Grzegorz Jaszczyk <[email protected]>; [email protected]; Nadav Haklai <[email protected]>; Gao, Liming <[email protected]>; Kinney, Michael D <[email protected]> Subject: Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee
On Wed, 26 Sep 2018 at 02:36, Zeng, Star <[email protected]> wrote: > > Just pushed it at e5cd809087e5710e019d2766fab13c59a2e2ac28. > Really thanks. > FYI this patch fixes the issue with my PCIe Renesas uPD70201 XHCI controller as well. > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, September 26, 2018 8:30 AM > To: Marcin Wojtas <[email protected]>; [email protected] > Cc: Tian, Feng <[email protected]>; Kinney, Michael D > <[email protected]>; Gao, Liming <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; Ni, Ruiyu > <[email protected]>; Wang, Fei1 <[email protected]>; Zeng, Star > <[email protected]> > Subject: RE: [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory > access in XhcSetHsee > > Good observation. > > Reviewed-by: Star Zeng <[email protected]> > > > Thanks, > Star > -----Original Message----- > From: Marcin Wojtas [mailto:[email protected]] > Sent: Wednesday, September 26, 2018 5:58 AM > To: [email protected] > Cc: Tian, Feng <[email protected]>; Kinney, Michael D > <[email protected]>; Gao, Liming <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Ni, Ruiyu <[email protected]>; Wang, Fei1 > <[email protected]>; Zeng, Star <[email protected]> > Subject: [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory > access in XhcSetHsee > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1206 > > Newly added XhcSetHsee() routine reads 4 bytes into a UINT16 variable causing > issues on PCIE and NonDiscoverable Xhci controllers. Fix that. > > Cc: Ruiyu Ni <[email protected]> > Cc: Fei1 Wang <[email protected]> > Cc: Star Zeng <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas <[email protected]> > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > index 89f073e..3ed1a55 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > @@ -609,7 +609,7 @@ XhcSetHsee ( > PciIo, > EfiPciIoWidthUint16, > PCI_COMMAND_OFFSET, > - sizeof (XhciCmd), > + sizeof (XhciCmd) / sizeof (UINT16), > &XhciCmd > ); > if (!EFI_ERROR (Status)) { > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
