Hi Haojian,
I will start with a few high-level requests:
- Could you rework this for inclusion in edk2-platforms instead?
Silicon/Synopsys I guess?
- Could you submit Usb2 and Usb3 support in a single set for v2?
- Can you convert these to UEFI driver model with
NonDiscoverableDeviceRegistrationLib instead of a hard-coded base
address?
I will provide detailed feedback on the individual patches separately,
so please wait for that before creating a v2.
/
Leif
On Mon, Aug 20, 2018 at 06:31:23PM +0800, Haojian Zhuang wrote:
> Changelog:
> v1:
> * Add Designware USB 3.0 device driver.
>
> Haojian Zhuang (2):
> EmbeddedPkg: add DwUsb protocol
> EmbeddedPkg/Drivers: add DwUsb3Dxe driver
>
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c | 2434
> +++++++++++++++++++++++++++
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec | 44 +
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h | 632 +++++++
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf | 52 +
> EmbeddedPkg/Include/Protocol/DwUsb.h | 81 +
> 5 files changed, 3243 insertions(+)
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf
> create mode 100644 EmbeddedPkg/Include/Protocol/DwUsb.h
>
> Cc: Leif Lindholm <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
