Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Jiaxin Wu > Sent: Sunday, October 07, 2018 8:03 PM > To: [email protected] > Cc: Carsey, Jaben <[email protected]>; Ye, Ting <[email protected]>; > Fu, Siyuan <[email protected]>; Wu, Jiaxin <[email protected]>; Bi, > Dandan <[email protected]> > Subject: [edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct > comments to align with the input parameter. > Importance: High > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230 > > Cc: Carsey Jaben <[email protected]> > Cc: Fu Siyuan <[email protected]> > Cc: Ye Ting <[email protected]> > Cc: Bi Dandan <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin <[email protected]> > --- > ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > index d4391b9f33..ccf7abde42 100644 > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > @@ -163,10 +163,11 @@ GetFileSize ( > @param[in] Mtftp4 MTFTP4 protocol interface > @param[in] FilePath Path of the file, Unicode encoded > @param[in] AsciiFilePath Path of the file, ASCII encoded > @param[in] FileSize Size of the file in number of bytes > @param[in] BlockSize Value of the TFTP blksize option > + @param[in] WindowSize Value of the TFTP window size option > @param[out] Data Address where to store the address of the > buffer > where the data of the file were downloaded in > case of success. > > @retval EFI_SUCCESS The file was downloaded. > @@ -904,10 +905,11 @@ Error : > @param[in] Mtftp4 MTFTP4 protocol interface > @param[in] FilePath Path of the file, Unicode encoded > @param[in] AsciiFilePath Path of the file, ASCII encoded > @param[in] FileSize Size of the file in number of bytes > @param[in] BlockSize Value of the TFTP blksize option > + @param[in] WindowSize Value of the TFTP window size option > @param[out] Data Address where to store the address of the > buffer > where the data of the file were downloaded in > case of success. > > @retval EFI_SUCCESS The file was downloaded. > -- > 2.17.1.windows.2 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
