On 10/8/2018 11:15 PM, Laszlo Ersek wrote:
On 10/08/18 16:32, Bi, Dandan wrote:
what were the practical consequences (symptoms) of this issue? Did some
checkboxes not work? (I'm asking because SecureBootConfigDxe uses some
checkboxes.)
1. The bug is in function "UpdateDefaultSettingInFormPackage()" which is to
update the default setting of some HII Questions in the IFR binary data. So it only has
impact when platform overrides default setting in HII VarStore through DynamicHii PCD
setting in Platform DSC file. If platform doesn't override default setting, it has no
impact.
2. The implementation updates the "Flags" filed in the EFI_IFR_CHECKBOX
structure to update the default setting of checkbox.
If using "IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);" when wants to update
the " Flags" filed in checkbox, but in fact it will update the opcode binary data(opcode
binary length) behind checkbox binary.
And then it will cause Browser can't parse the IFR binary data correctly. And
then the possible symptom is that some HII Question and forms may be not parsed
and then cannot be shown.
Thanks! I've copied this into the BZ.
Has this patch been pushed? If not, maybe you could also copy the above
description in the commit message.
A commit message that describes what to be fixed is more meaningful.
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
