On 10/09/18 10:59, Ni, Ruiyu wrote: > On 10/9/2018 4:25 PM, Laszlo Ersek wrote:
>> - for clarity, please use ~(UINTN)BIT31 as mask (even though it makes no >> practical difference). > Actually we could use IA32_CR0 structure to avoid BIT31 usage. That's a great idea. I wish I had known about IA32_CR0 (and IA32_CR4) earlier! Now we have a bunch of ad-hoc bitmask macros around the tree, e.g. CR0_WP, CR0_PG, CR4_PSE, CR4_PAE in "UefiCpuPkg/CpuDxe/CpuPageTable.c". Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
