Thanks!
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, October 9, 2018 6:14 PM > To: Zeng, Star <star.z...@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org>; Gao, Liming <liming....@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning > misleading-indentation > > On 10/09/18 10:24, Zeng, Star wrote: > > Reviewed-by: Star Zeng <star.z...@intel.com> > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > > Biesheuvel > > Sent: Tuesday, October 9, 2018 3:13 PM > > To: Gao, Liming <liming....@intel.com> > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning > > misleading-indentation > > > > On 9 October 2018 at 09:11, Gao, Liming <liming....@intel.com> wrote: > >> This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and > >> IntelFrameworkModulepkg is for decode. So, other copy > SDK has no this issue. > >> > > > > I understand. > > > > Thanks for the fix > > > > Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > In the commit message, I referenced > <https://bugzilla.tianocore.org/show_bug.cgi?id=1234>, which got > reported meanwhile. > > Pushed as commit 50431b9cc70c. > > Thanks > Laszlo > > >>> -----Original Message----- > >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >>> Ard Biesheuvel > >>> Sent: Tuesday, October 9, 2018 3:08 PM > >>> To: Gao, Liming <liming....@intel.com> > >>> Cc: edk2-devel@lists.01.org > >>> Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning > >>> misleading-indentation > >>> > >>> On 9 October 2018 at 09:06, Liming Gao <liming....@intel.com> wrote: > >>>> GCC 6 or above reports the warning misleading-indentation. > >>>> This patch fixes it. > >>>> > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>> Signed-off-by: Liming Gao <liming....@intel.com> > >>>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > >>>> --- > >>>> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> index bebe664..e281716 100644 > >>>> --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 > >>>> position) > >>>> unsigned limit = p->numFastBytes + 1; > >>>> if (limit > numAvailFull) > >>>> limit = numAvailFull; > >>>> - for (len = 3; len < limit && data[len] == data2[len]; len++); > >>>> + for (len = 3; len < limit && data[len] == data2[len]; len++) > >>>> + { > >>>> + } > >>>> > >>>> { > >>>> unsigned state2 = kLiteralNextStates[state]; > >>> > >>> Thanks Liming. > >>> > >>> Don't we need this change in all copies of the LZMA SDK? > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
