Liming, The fact that the set includes unreviewed patches[1] should be sufficient argument for reverting it immediately.
[1] ea787b6b55499e8f931201f8f49daaaeb2e4409f But beyond that, a set this invasive should only ever be pushed in the days after a stable tag has been created - not 2/3 through the period. This particular one breaks builds using the instructions from https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions With the new set, it is mandatory that edksetup.sh is sourced before building BaseTools. That was not previously the case, meaning existing CI jobs following the documentation example now fail. Please revert this set for now. We can revisit and plan a suitable way forward after that. Regards, Leif On Sat, Oct 13, 2018 at 08:44:39AM +0000, Gao, Liming wrote: > Ard: > I pull the latest edk2 code. I can find RunTests.py in > BaseTools/Tests. The below error message shows RunTests.py is not > found. But, this file is in BaseTools/Tests. I also run Make > command in BaseTools directory. It can work in my Ubuntu > machine. I install Python37. Do you install Python36 or Python37 > in your machine? > > Yonghong has sent the mail to notify BaseTools Python3 migration > is done. Python3.6 or the above is required. > > > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of Ard > > Biesheuvel > > Sent: Saturday, October 13, 2018 4:18 PM > > To: edk2-devel-01 <[email protected]>; Gao, Liming > > <[email protected]>; Laszlo Ersek <[email protected]>; Leif Lindholm > > <[email protected]>; Kinney, Michael D <[email protected]>; > > Zhu, Yonghong <[email protected]>; > > [email protected] > > Subject: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX > > > > Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f > > > > "BaseTools: update Test scripts support python3" > > > > [which has never been sent out for review to the mailing list, as far > > as I can tell] is breaking the BaseTools build > > > > make -C Tests > > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > > /bin/sh: 1: RunTests.py: not found > > GNUmakefile:17: recipe for target 'test' failed > > make[1]: *** [test] Error 127 > > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > > GNUmakefile:25: recipe for target 'Tests' failed > > make: *** [Tests] Error 2 > > make: Leaving directory '/home/ard/build/edk2/BaseTools' > > > > I tried reverting that patch alone, but that gives me > > > > make -C Tests > > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > > Traceback (most recent call last): > > File "RunTests.py", line 36, in <module> > > allTests = GetAllTestsSuite() > > File "RunTests.py", line 33, in GetAllTestsSuite > > return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()]) > > File "RunTests.py", line 30, in GetPythonTestSuite > > return PythonToolsTests.TheTestSuite() > > File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py", > > line 27, in TheTestSuite > > import CheckUnicodeSourceFiles > > File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py", > > line 25, in <module> > > from Common.Misc import PathClass > > File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py", > > line 27, in <module> > > from collections import UserDict as IterableUserDict > > ImportError: cannot import name UserDict > > GNUmakefile:17: recipe for target 'test' failed > > make[1]: *** [test] Error 1 > > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > > GNUmakefile:25: recipe for target 'Tests' failed > > make: *** [Tests] Error 2 > > make: Leaving directory '/home/ard/build/edk2/BaseTools' > > > > Breaking the build for everyone with an unreviewed patch 2 days before > > the plugfest is NOT OK. > > > > Please fix or revert ASAP > > > > (I suppose that the failing test is a false negative in this case, but > > that is not really the point - my CI jobs are broken due to this and > > so are many others, I imagine) > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
