Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, October 15, 2018 5:46 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix bugs use special character in the --pcd > option > > Cases: > --pcd Token.Name="!" > --pcd Token.Name="\'W&\'" > --pcd Token.Name="2*h" > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu <yonghong....@intel.com> > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index aaef404..1a0a293 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -1078,10 +1078,12 @@ class DscBuildData(PlatformBuildClassObject): > if PcdValue.upper() == 'TRUE': > PcdValue = str(1) > if not FieldName: > if PcdDatumType not in TAB_PCD_NUMERIC_TYPES: > PcdValue = '"' + PcdValue + '"' > + elif not PcdValue.isdigit() and not > PcdValue.upper().startswith('0X'): > + PcdValue = '"' + PcdValue + '"' > else: > IsArray = False > Base = 10 > if PcdValue.upper().startswith('0X'): > Base = 16 > -- > 2.6.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
