Hi, Kim, Looks good to me. Reviewed-by: Maurice Ma <[email protected]>
-Maurice -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Wonkyu Kim Sent: Monday, October 15, 2018 15:45 To: [email protected] Cc: Williams, Hannah <[email protected]>; [email protected]; Zhao, Lijian <[email protected]>; Kim, Wonkyu <[email protected]>; [email protected]; Agyeman, Prince <[email protected]> Subject: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build From: Wonkyu Kim <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wonkyu Kim <[email protected]> --- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++ CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc index b6cdb697a5b0..7d5052be9301 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -263,7 +263,11 @@ # ################################################################################ [PcdsFeatureFlag] +!if $(TARGET) == DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE +!else + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE +!endif gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc index c3fe099e5fec..0484e941cce7 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -263,7 +263,11 @@ # ################################################################################ [PcdsFeatureFlag] +!if $(TARGET) == DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE +!else + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE +!endif gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE -- 2.17.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
