Laszlo: Sorry for the delay. Your change is good. Reviewed-by: Liming Gao <[email protected]>
Thanks Liming >-----Original Message----- >From: Kinney, Michael D >Sent: Tuesday, October 16, 2018 3:29 AM >To: Laszlo Ersek <[email protected]>; Gao, Liming <[email protected]>; >Kinney, Michael D <[email protected]> >Cc: edk2-devel-01 <[email protected]> >Subject: RE: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, >cleanups > >Laszlo, > >Thanks for the reminder. My knowledge of inline >GCC assembly syntax is very limited, so I am not >able to review this patch for correctness. I can >ack it. > >Acked-by: Michael D Kinney <[email protected]> > >Perhaps Liming can do a more complete review. > >Mike > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel- >> [email protected]] On Behalf Of Laszlo Ersek >> Sent: Monday, October 15, 2018 11:05 AM >> To: Kinney, Michael D <[email protected]>; Gao, >> Liming <[email protected]> >> Cc: edk2-devel-01 <[email protected]> >> Subject: Re: [edk2] [PATCH 0/5] >> MdePkg/BaseSynchronizationLib GCC: fixes, cleanups >> >> On 10/08/18 15:44, Laszlo Ersek wrote: >> > On 09/30/18 00:23, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> >> Branch: inline_asm_rw_ops_1208 >> >> >> >> This series mainly fixes the operand constraints >> (missing input-output >> >> qualifications) in >> "BaseSynchronizationLib/*/GccInline.c". >> >> >> >> (It would be better to remove these files altogether >> in favor of the >> >> already existing NASM implementation, but due to >> >> <https://bugzilla.tianocore.org/show_bug.cgi?id=881>, >> we can't generally >> >> do that in libraries yet.) >> >> >> >> Cc: Liming Gao <[email protected]> >> >> Cc: Michael D Kinney <[email protected]> >> >> >> >> Thanks, >> >> Laszlo >> >> >> >> Laszlo Ersek (5): >> >> MdePkg/BaseSynchronizationLib GCC: fix whitespace >> and comments >> >> MdePkg/BaseSynchronizationLib GCC: fix >> InternalSyncCompareExchange16() >> >> MdePkg/BaseSynchronizationLib GCC: fix >> InternalSyncCompareExchange32() >> >> MdePkg/BaseSynchronizationLib GCC: fix X64 >> >> InternalSyncCompareExchange64() >> >> MdePkg/BaseSynchronizationLib GCC: simplify IA32 >> >> InternalSyncCompareExchange64() >> >> >> >> >> MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c | >> 42 +++++++---------- >> >> >> MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c | >> 47 +++++++------------- >> >> 2 files changed, 34 insertions(+), 55 deletions(-) >> >> >> > >> > Ping :) >> >> Ping >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
