Hi Eric, On 10/18/18 09:34, Eric Dong wrote: > V3 changes: > 1. Use global variable instead of internal function to return string for > register type > and dependence type. > 2. Add comments for some complicated logic. > > V1 changes: > Because this driver needs to set MSRs saved in normal boot phase, sync > semaphore logic from RegisterCpuFeaturesLib code which used for normal boot > phase. > > Detail see below change for RegisterCpuFeaturesLib: > UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type. > > Cc: Ruiyu Ni <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong <[email protected]> > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 385 > ++++++++++++++++++----------- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 3 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 3 +- > 3 files changed, 248 insertions(+), 143 deletions(-)
I've checked my comments for v1 against this version (v3). They have all been addressed, except (13) and (14). Regarding those, I elaborated under patch v3 5/6 already. Basically, PiSmmCpuDxeSmm should continue to work without problems if a platform takes the "empty RegisterTable and PreSmmInitRegisterTable" branch in CpuS3DataDxe. With those comments addressed, I'd be ready to regression-test the next version of the series. Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
