On 22 October 2018 at 12:07, Gao, Liming <[email protected]> wrote: > Ard, Leif and Mike: > Have you any comments on this change? This patch updates all platform > DSC/FDF in edk2-platform master to refer to FatPkg instead of FatBinPkg, > because we will remove FatBinPkg. >
Reviewed-by: Ard Biesheuvel <[email protected]> Please apply this patch first, and only then apply the edk2 patch to remove FatBinPkg. Thanks, Ard. >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf Of Gao, >> Liming >> Sent: Wednesday, October 17, 2018 9:11 PM >> To: Zhang, Shenglei <[email protected]>; [email protected] >> Subject: Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg >> >> Ard: >> Do you know who can review this patch? >> >> Thanks >> Liming >> > -----Original Message----- >> > From: edk2-devel [mailto:[email protected]] On Behalf Of >> > shenglei >> > Sent: Tuesday, October 16, 2018 11:43 AM >> > To: [email protected] >> > Subject: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg >> > >> > In order to remove FatBinPkg, relationships depend on >> > FatBinPkg need to be replaced by FatPkg in fdf. And >> > FatPkg needs to be added in dsc. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Shenglei Zhang <[email protected]> >> > --- >> > Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + >> > Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- >> > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + >> > Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +- >> > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +- >> > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 2 +- >> > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 1 + >> > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +- >> > Platform/Hisilicon/D03/D03.dsc | 1 + >> > Platform/Hisilicon/D03/D03.fdf | 2 +- >> > Platform/Hisilicon/D05/D05.dsc | 1 + >> > Platform/Hisilicon/D05/D05.fdf | 2 +- >> > Platform/Hisilicon/HiKey/HiKey.dsc | 1 + >> > Platform/Hisilicon/HiKey/HiKey.fdf | 2 +- >> > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + >> > Platform/Hisilicon/HiKey960/HiKey960.fdf | 2 +- >> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + >> > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 +- >> > 18 files changed, 18 insertions(+), 10 deletions(-) >> > >> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc >> > b/Platform/ARM/JunoPkg/ArmJuno.dsc >> > index 8d6dd0207d..ac3d63bd4d 100644 >> > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc >> > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc >> > @@ -293,6 +293,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # Required by PCI >> > ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf >> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf >> > b/Platform/ARM/JunoPkg/ArmJuno.fdf >> > index c538a9b754..0a8b636d0e 100644 >> > --- a/Platform/ARM/JunoPkg/ArmJuno.fdf >> > +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf >> > @@ -142,7 +142,7 @@ FvNameGuid = >> > B73FE497-B92E-416e-8326-45AD0D270092 >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > # Required by PCI >> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc >> > b/Platform/ARM/SgiPkg/SgiPlatform.dsc >> > index 2d8dcff94d..3f0ca9872e 100644 >> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc >> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc >> > @@ -264,6 +264,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # >> > # Bds >> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf >> > b/Platform/ARM/SgiPkg/SgiPlatform.fdf >> > index 161ff92bbd..fd87563246 100644 >> > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf >> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf >> > @@ -150,7 +150,7 @@ READ_LOCK_STATUS = TRUE >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > # FV FileSystem >> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> > b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> > index 6405d955f1..617164d42a 100644 >> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> > @@ -265,7 +265,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > - >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf >> > >> > # >> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf >> > b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf >> > index 5786f117ea..ecd57f3a3e 100644 >> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf >> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf >> > @@ -123,7 +123,7 @@ FvNameGuid = >> > 73dcb643-3862-4904-9076-a94af1890243 >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > # Versatile Express FileSystem >> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> > b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> > index ca19fd6526..d20f1a7387 100644 >> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> > @@ -294,6 +294,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # >> > # Bds >> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf >> > b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf >> > index 305e661a2b..239029d05c 100644 >> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf >> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf >> > @@ -128,7 +128,7 @@ FvNameGuid = >> > 87940482-fc81-41c3-87e6-399cf85ac8a0 >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > # >> > diff --git a/Platform/Hisilicon/D03/D03.dsc >> > b/Platform/Hisilicon/D03/D03.dsc >> > index 116d591363..aa1da5d61f 100644 >> > --- a/Platform/Hisilicon/D03/D03.dsc >> > +++ b/Platform/Hisilicon/D03/D03.dsc >> > @@ -430,6 +430,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > MdeModulePkg/Application/UiApp/UiApp.inf { >> > <LibraryClasses> >> > diff --git a/Platform/Hisilicon/D03/D03.fdf >> > b/Platform/Hisilicon/D03/D03.fdf >> > index b23765020d..f8a3c0cdaa 100644 >> > --- a/Platform/Hisilicon/D03/D03.fdf >> > +++ b/Platform/Hisilicon/D03/D03.fdf >> > @@ -197,7 +197,7 @@ READ_LOCK_STATUS = TRUE >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > INF >> > IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf >> > >> > diff --git a/Platform/Hisilicon/D05/D05.dsc >> > b/Platform/Hisilicon/D05/D05.dsc >> > index a6bb65e71a..1040466633 100644 >> > --- a/Platform/Hisilicon/D05/D05.dsc >> > +++ b/Platform/Hisilicon/D05/D05.dsc >> > @@ -584,6 +584,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > MdeModulePkg/Application/UiApp/UiApp.inf { >> > <LibraryClasses> >> > diff --git a/Platform/Hisilicon/D05/D05.fdf >> > b/Platform/Hisilicon/D05/D05.fdf >> > index af2d20db9d..a933af3635 100644 >> > --- a/Platform/Hisilicon/D05/D05.fdf >> > +++ b/Platform/Hisilicon/D05/D05.fdf >> > @@ -201,7 +201,7 @@ READ_LOCK_STATUS = TRUE >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > INF >> > IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf >> > >> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc >> > b/Platform/Hisilicon/HiKey/HiKey.dsc >> > index 9c1fc2e1b4..43bacfd146 100644 >> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc >> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc >> > @@ -257,6 +257,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # >> > # Bds >> > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf >> > b/Platform/Hisilicon/HiKey/HiKey.fdf >> > index 2bca7232b6..577f05afb7 100644 >> > --- a/Platform/Hisilicon/HiKey/HiKey.fdf >> > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf >> > @@ -179,7 +179,7 @@ READ_LOCK_STATUS = TRUE >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > INF >> > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc >> > b/Platform/Hisilicon/HiKey960/HiKey960.dsc >> > index be13714b9c..90a28b53cc 100644 >> > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc >> > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc >> > @@ -235,6 +235,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # >> > # Bds >> > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf >> > b/Platform/Hisilicon/HiKey960/HiKey960.fdf >> > index d65f778785..61cbe4e8a7 100644 >> > --- a/Platform/Hisilicon/HiKey960/HiKey960.fdf >> > +++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf >> > @@ -168,7 +168,7 @@ READ_LOCK_STATUS = TRUE >> > # >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > INF >> > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> > b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> > index d4c67a2d11..ef5bcb757c 100644 >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> > @@ -525,6 +525,7 @@ >> > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > + FatPkg/EnhancedFatDxe/Fat.inf >> > >> > # Bds - Use Intel BDS >> > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> > b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> > index c064a434b0..c5fbef5681 100644 >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> > @@ -186,7 +186,7 @@ FvNameGuid = >> > 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> > # FAT filesystem + GPT/MBR partitioning >> > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> > - INF FatBinPkg/EnhancedFatDxe/Fat.inf >> > + INF FatPkg/EnhancedFatDxe/Fat.inf >> > INF >> > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> > >> > # UEFI application (Shell Embedded Boot Loader) >> > -- >> > 2.18.0.windows.1 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > [email protected] >> > https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
