> -----Original Message----- > From: Zeng, Star > Sent: Tuesday, October 23, 2018 1:46 PM > To: Paulo Alcantara; Wu, Hao A; [email protected] > Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > On 2018/10/22 22:39, Paulo Alcantara wrote: > > Hao Wu <[email protected]> writes: > > > >> The series will address a couple of bugs within the UDF related codes. > >> > >> Please refer to the log message of each commit for more details. > >> > >> Cc: Paulo Alcantara <[email protected]> > >> Cc: Ruiyu Ni <[email protected]> > >> Cc: Jiewen Yao <[email protected]> > >> Cc: Star Zeng <[email protected]> > >> > >> Hao Wu (10): > >> MdeModulePkg/PartitionDxe: Add check for underlying device block size > >> MdeModulePkg/UdfDxe: Refine boundary checks for file/path name > string > >> MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE > >> MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier > decode > >> MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) > size > >> MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() > >> MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() > >> MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info > request > >> MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd > >> MdeModulePkg/UdfDxe: Avoid possible use of already-freed data > >> > >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 28 +++ > >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 ++++---- > >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 > ++++++++++++++++++-- > >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 ++++- > >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + > >> 5 files changed, 362 insertions(+), 79 deletions(-) > > > > For the series: > > > > Reviewed-by: Paulo Alcantara <[email protected]> > > I could not review the in detail. > Thanks Paulo's Reviewed-by. > > I have two minor feedback. > 1. I saw some place using 'basic validations' and some place using > 'basic validation', should they be aligned? > 2. I think you can add "Copyright (c) 2018, Intel Corporation. All > rights reserved.<BR>" for every file you changed. > > Acked-by: Star Zeng <[email protected]>
Thanks. I will address the above 2 points before push. Best Regards, Hao Wu > > Thanks, > Star > > > > > Thanks! > > Paulo > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
