Changes include: 1. Remove extra white space at the end of line. 2. Add comments for the new add function parameter. 3. Update IN OUT tag for function parameter.
Cc: Dandan Bi <[email protected]> Cc: Ruiyu Ni <[email protected]> Cc: Laszlo Ersek <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong <[email protected]> --- .../PeiRegisterCpuFeaturesLib.c | 2 ++ .../RegisterCpuFeaturesLib.c | 24 +++++++++++----------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c index a688e03152..4bab2837cc 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c @@ -146,6 +146,8 @@ GetProcessorInformation ( @param[in] Procedure A pointer to the function to be run on enabled APs of the system. + @param[in] MpEvent The Event used to sync the result. + **/ VOID StartupAPsWorker ( diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 5b49bc4504..b6e108b8ad 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -160,7 +160,7 @@ DetectFeatureScope ( /** Clear dependence for the specified type. - @param[in] CurrentFeature Cpu feature need to clear. + @param[in] CpuFeature Cpu feature need to clear. @param[in] Before Before or after dependence relationship. **/ @@ -202,14 +202,14 @@ ClearFeatureScope ( /** Base on dependence relationship to asjust feature dependence. - ONLY when the feature before(or after) the find feature also has + ONLY when the feature before(or after) the find feature also has dependence with the find feature. In this case, driver need to base on dependce relationship to decide how to insert current feature and adjust the feature dependence. - @param[in] PreviousFeature CPU feature current before the find one. - @param[in] CurrentFeature Cpu feature need to adjust. - @param[in] Before Before or after dependence relationship. + @param[in, out] PreviousFeature CPU feature current before the find one. + @param[in, out] CurrentFeature Cpu feature need to adjust. + @param[in] Before Before or after dependence relationship. @retval TRUE means the current feature dependence has been adjusted. @@ -239,7 +239,7 @@ AdjustFeaturesDependence ( } // - // If both feature have dependence, keep the one which needs use more + // If both feature have dependence, keep the one which needs use more // processors and clear the dependence for the other one. // if (PreDependType >= CurrentDependType) { @@ -254,10 +254,10 @@ AdjustFeaturesDependence ( /** Base on dependence relationship to asjust feature order. - @param[in] FeatureList Pointer to CPU feature list - @param[in] FindEntry The entry this feature depend on. - @param[in] CurrentEntry The entry for this feature. - @param[in] Before Before or after dependence relationship. + @param[in] FeatureList Pointer to CPU feature list + @param[in, out] FindEntry The entry this feature depend on. + @param[in, out] CurrentEntry The entry for this feature. + @param[in] Before Before or after dependence relationship. **/ VOID @@ -279,8 +279,8 @@ AdjustEntry ( // base on dependence type of feature A and B to update the logic here. // For example, feature A has package type dependence and feature B has core type dependence, // because package type dependence need to wait for more processors which has strong dependence - // than core type dependence. So driver will adjust the feature order to B -> A -> C. and driver - // will remove the feature dependence in feature B. + // than core type dependence. So driver will adjust the feature order to B -> A -> C. and driver + // will remove the feature dependence in feature B. // Driver just needs to make sure before feature C been executed, feature A has finished its task // in all all thread. Feature A finished in all threads also means feature B have finshed in all // threads. -- 2.15.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
