Thanks for all the reviews, I just pushed the patches at https://github.com/tianocore/edk2/compare/a6eb94e...0cd6452.
Star -----Original Message----- From: Zeng, Star Sent: Friday, October 26, 2018 9:41 PM To: [email protected] Cc: Zeng, Star <[email protected]>; Ni, Ruiyu <[email protected]>; Wu, Hao A <[email protected]>; Wang, Jian J <[email protected]>; Yao, Jiewen <[email protected]> Subject: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer V3: Thanks for Hao's feedback. 1. Match function parameter name and description between XhciSched.c and XhciSched.h, EhciSched.c and EhciSched.h. 2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb. V2: Thanks for Ray's feedback. 1. Add the missing "FreePool (Data);". 2. Remove the unnecessary indentation change. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Please refer to the log message of each commit for more details. Cc: Ruiyu Ni <[email protected]> Cc: Hao Wu <[email protected]> Cc: Jian J Wang <[email protected]> Cc: Jiewen Yao <[email protected]> Star Zeng (4): MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 28 +---- MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 114 +++++++++---------- MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.h | 35 +++++- MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 38 ++++++- MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h | 33 +++--- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 19 +--- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 185 +++++++++++++++++-------------- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 55 +++++++-- 8 files changed, 296 insertions(+), 211 deletions(-) -- 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
