Reviewed-by: Star Zeng <[email protected]>
Thanks, Star -----Original Message----- From: Ni, Ruiyu Sent: Monday, October 29, 2018 11:56 AM To: [email protected] Cc: Zeng, Star <[email protected]> Subject: [PATCH] MdeModulePkg/UsbBusDxe: Add missing "return NULL" in UsbCreateDesc() When (Len < Offset) is TRUE, indicating the data to visit is beyond the boundary, the error message is printed but the function doesn't return NULL. It's a typo when modifying the commit 4c034bf62. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni <[email protected]> Cc: Star Zeng <[email protected]> --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c index 7ff31bb656..d286c81327 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c @@ -229,6 +229,7 @@ UsbCreateDesc ( // if (Len < Offset) { DEBUG ((DEBUG_ERROR, "UsbCreateDesc: met mal-format descriptor, Offset/Len = %d/%d!\n", Offset, Len)); + return NULL; } if ((Head->Type != Type) || (Head->Len < DescLen)) { -- 2.16.1.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
