Hi Shenglei, I am happy with this change, but I think the deletion from Maintainers.txt should come last (as 3/3). Could you rework and resubmit, and add a cover letter (0/3)?
Best Regards, Leif On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > Given that EdkShellPkg and EkdShellBinPkg will be removed, > information about them in Maintainers.txt should also be > deleted. > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > Cc: Andrew Fish <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Leif Lindholm <[email protected]> > Cc: Michael D Kinney <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <[email protected]> > --- > Maintainers.txt | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 36c6689afd..98f104b674 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > M: Liming Gao <[email protected]> > > -EdkShellPkg, EdkShellBinPkg > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > -M: Ruiyu Ni <[email protected]> > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > - > EmbeddedPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > M: Leif Lindholm <[email protected]> > -- > 2.18.0.windows.1 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
