Yes. I will wait for another patch in this patch set to be reviewed.
>-----Original Message----- >From: Zeng, Star >Sent: Friday, November 02, 2018 1:00 PM >To: Gao, Liming <[email protected]>; Jeff Brasen <[email protected]>; >Ni, Ruiyu <[email protected]>; [email protected] >Cc: Kinney, Michael D <[email protected]>; Gao, Liming ><[email protected]>; Zeng, Star <[email protected]> >Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >Liming, > >Will you help push the patch series? > > >Thanks, >Star > >-----Original Message----- >From: edk2-devel [mailto:[email protected]] On Behalf Of Gao, >Liming >Sent: Thursday, November 1, 2018 9:31 PM >To: Jeff Brasen <[email protected]>; Ni, Ruiyu <[email protected]>; edk2- >[email protected] >Cc: Kinney, Michael D <[email protected]>; Gao, Liming ><[email protected]> >Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >Jeff: > Thanks for your case. PrePiMemoryAllocationLib is a MemoryAllocationLib >implementation that doesn't depend on PEI or DXE service. So, >MemoryAllocationLib may be used in BASE type. And, I find >MdeModulePkg\Library\BaseBmpSupportLib\BaseBmpSupportLib.inf is BASE >type and consumes MemoryAllocationLib. So, I think your change is OK. >Reviewed-by: Liming Gao <[email protected]> > >Thanks >Liming >From: Jeff Brasen [mailto:[email protected]] >Sent: Thursday, November 1, 2018 2:25 PM >To: Ni, Ruiyu <[email protected]>; [email protected] >Cc: Gao, Liming <[email protected]>; Kinney, Michael D ><[email protected]> >Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > > >For defining it as a BASE type i changed that to that as there is a >MemoryAllocationLib defined for the various phases. For example, SEC uses >EmbeddedPkg/Library/PrePiMemoryAllocationLib (other patch in this series >implements the AllocateZeroPool that is needed for this). > > > >I am not opposed to an allocation-less SortLib but was trying to enable this >capability without impact to other users of this library. > > > >Thanks, > >Jeff > >________________________________ >From: Ni, Ruiyu <[email protected]<mailto:[email protected]>> >Sent: Wednesday, October 31, 2018 2:56:42 AM >To: Jeff Brasen; [email protected]<mailto:[email protected]> >Cc: Gao, Liming; Kinney, Michael D >Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >SortLib depends on MemoryAllocationLib. >How can it be a BASE type library? > >Can we do it in two options? >1. Change the SortLib API to accept a temporary buffer from caller. So the >MemoryAllocationlIb dependency can be removed. >2. Do not change SortLibAPI but uses a fixed-size temporary buffer internally. >E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE]; > > >Thanks/Ray > >> -----Original Message----- >> From: edk2-devel >> <[email protected]<mailto:[email protected] >> g>> On Behalf Of Jeff Brasen >> Sent: Wednesday, October 31, 2018 5:31 AM >> To: [email protected]<mailto:[email protected]> >> Cc: Jeff Brasen <[email protected]<mailto:[email protected]>> >> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >> module types >> >> Expose BaseSortLib for use in SEC and PEI phases. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jeff Brasen >> <[email protected]<mailto:[email protected]>> >> --- >> MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> index f807cd7..5bd1aa1 100644 >> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> @@ -18,9 +18,9 @@ >> BASE_NAME = BaseSortLib >> MODULE_UNI_FILE = BaseSortLib.uni >> FILE_GUID = 03F3331B-F12D-494f-BF37-E55A657F2497 >> - MODULE_TYPE = UEFI_DRIVER >> + MODULE_TYPE = BASE >> VERSION_STRING = 1.0 >> - LIBRARY_CLASS = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER >> UEFI_APPLICATION UEFI_DRIVER >> + LIBRARY_CLASS = SortLib >> >> # >> # VALID_ARCHITECTURES = IA32 X64 EBC >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> [email protected]<mailto:[email protected]> >> https://lists.01.org/mailman/listinfo/edk2-devel >________________________________ >This email message is for the sole use of the intended recipient(s) and may >contain confidential information. Any unauthorized review, use, disclosure or >distribution is prohibited. If you are not the intended recipient, please >contact >the sender by reply email and destroy all copies of the original message. >________________________________ >_______________________________________________ >edk2-devel mailing list >[email protected] >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
