Hi, Shenglei, Thank you for the patch.
I saw many other references in CorebootPayloadPkg DSC files for FULL_BIN. I think we should remove all of them from both DSC and FDF at the same time. The current SHELL_TYPE defined in DSC file is FULL_BIN. It needs to be changed to UEFI_BIN. Otherwise, the final image will not have any Shell module included since FULL_BIN is removed in FDF. Thanks Maurice -----Original Message----- From: Zhang, Shenglei Sent: Wednesday, October 31, 2018 23:27 To: [email protected] Cc: Ma, Maurice <[email protected]>; Agyeman, Prince <[email protected]>; You, Benjamin <[email protected]> Subject: [PATCH v2 1/5] CorebootPayloadPkg: Remove EdkShellBinPkg in FDF Remove EdkShellBinPkg in CorebootPayloadPkg.fdf. https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: Maurice Ma <[email protected]> Cc: Prince Agyeman <[email protected]> Cc: Benjamin You <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <[email protected]> --- CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf index 7994f0c949..741a5c232e 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -185,14 +185,6 @@ INF ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf INF ShellPkg/Application/Shell/Shell.inf !endif -!if $(SHELL_TYPE) == FULL_BIN -!if $(ARCH) == IA32 -INF RuleOverride = BINARY USE = IA32 EdkShellBinPkg/FullShell/FullShell.inf -!else -INF RuleOverride = BINARY USE = X64 EdkShellBinPkg/FullShell/FullShell.inf -!endif -!endif - !if $(SHELL_TYPE) == MIN_BIN !if $(ARCH) == IA32 INF RuleOverride = BINARY USE = IA32 ShellBinPkg/MinUefiShell/MinUefiShell.inf -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
