Reviewed-by: David Wei <[email protected]>

Thanks,
David  Wei

Intel SSG/STO/UEFI BIOS                                 


-----Original Message-----
From: Gary Lin [mailto:[email protected]] 
Sent: Tuesday, October 30, 2018 3:57 PM
To: [email protected]
Cc: Wei, David <[email protected]>; Guo, Mang <[email protected]>; Kinney, 
Michael D <[email protected]>
Subject: [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of 
characters

Dereference MatchLang before comparing it with a character.

Cc: David Wei <[email protected]>
Cc: Mang Guo <[email protected]>
Cc: Michael D Kinney <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <[email protected]>
---
 .../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c 
b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
index 7cf3453a62f4..612e1261fdaa 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
@@ -73,7 +73,7 @@ CurrentLanguageMatch (
     // Find the best matching RFC 4646 language, compute the offset.
     //
     CompareLength = AsciiStrLen (BestLanguage);
-    for (MatchLang = Languages, (*Offset) = 0; MatchLang != '\0'; (*Offset)++) 
{
+    for (MatchLang = Languages, (*Offset) = 0; *MatchLang != '\0'; 
(*Offset)++) {
       //
       // Seek to the end of current match language.
       //
-- 
2.19.0

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to