On 6 November 2018 at 15:58, Laszlo Ersek <[email protected]> wrote: > On 11/06/18 12:26, Ard Biesheuvel wrote: >> On 5 November 2018 at 23:46, Laszlo Ersek <[email protected]> wrote: > >>> Assuming we consider "NetworkPkg/IScsiDxe/IScsiDxe.inf" an integral part >>> of the edk2 networking stack, without which (and its OpenSSL dependency) >>> noone would ever want to build OVMF, this patch is OK. >>> >>> I don't know what other OVMF users think about this; personally I'm ok >>> with it. >>> >>> Reviewed-by: Laszlo Ersek <[email protected]> >>> >> >> I think that is fine. >> >> Reviewed-by: Ard Biesheuvel <[email protected]> >> >> Since the delta between NETWORK_IP6_ENABLE on vs off is decreasing, >> any chance we could drop it altogether at some point? > > I believe I'd prefer flipping the default value at the most. UEFI has > been gaining new features like there's no tomorrow, and I find the > parallel (?) growth of the OVMF binary (mainly DXEFV) uncomfortable. > > I'd like to continue offering knobs to keep the included features under > control. >
Fair enough. From a testing/coverage POV, flipping the default already improves the situation significantly, so I can live with that. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
