On Tue, Nov 06, 2018 at 02:17:45PM +0530, Sakar Arora wrote: > As per SBBR specification, "A UEFI runtime environment compliant with > SBBR must not be written with any assumption of an identity mapping > between virtual and physical memory maps." > > Test case implementation was failing the test, if it is not identity > mapped, which is incorrect. > > Corrected test case to warn the user that UEFI runtime environment is > identity mapped, instead of failure. > > Signed-off-by: Sakar Arora <sakar.ar...@arm.com> > Reported-by: Felix Poludov <fel...@ami.com> > --- > .../SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c | 6 > +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > > b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > index fb50702..c88d60b 100644 > --- > a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > +++ > b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > @@ -201,13 +201,13 @@ BBTestMemoryMapTest ( > // > // Checking for identity mapping > // > - if (MemoryMapDescriptor->PhysicalStart != > MemoryMapDescriptor->VirtualStart) { > + if (MemoryMapDescriptor->PhysicalStart == > MemoryMapDescriptor->VirtualStart) { > StandardLib->RecordAssertion ( > StandardLib, > - EFI_TEST_ASSERTION_FAILED, > + EFI_TEST_ASSERTION_WARNING, > gSbbrBootServicesAssertion001Guid, > L"MemoryMap", > - L"%a:%d - MemoryMap 0x%X Not Identity Mapped", > + L"%a:%d - MemoryMap 0x%X is Identity Mapped. UEFI runtime > environment must not be written with any assumption of an identity mapping > between virtual and physical memory maps.", > __FILE__, > __LINE__, > MemoryMapDescriptor
This file was only added as part of this set - please fold this change into the original patch adding it. Development history before upstreaming is not something we need (or want) to track. / Leif > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel