On 11/09/18 04:34, Bi, Dandan wrote: > Hi Stewards and package maintainers: > > Since this is a clear bug. And the risk for this release is small. > So I plan to push this patch before edk2-stable201811 tag is created.
I agree, this is a bugfix, not a feature patch. Thanks, Laszlo > If you have any concern, please raise here. > > > Thanks, > Dandan > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, November 8, 2018 9:56 PM >> To: Bi, Dandan <[email protected]>; [email protected] >> Cc: Ni, Ruiyu <[email protected]>; Kinney, Michael D >> <[email protected]> >> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format >> in AcpiEx >> >> Reviewed-by: Liming Gao <[email protected]> >> >>> -----Original Message----- >>> From: Bi, Dandan >>> Sent: Thursday, November 8, 2018 9:50 PM >>> To: [email protected] >>> Cc: Ni, Ruiyu <[email protected]>; Kinney, Michael D >>> <[email protected]>; Gao, Liming <[email protected]> >>> Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text >>> format in AcpiEx >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 >>> >>> Text format for AcpiEx device path in UEFI Spec: >>> AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) >>> AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) >>> >>> When convert device path to text for ACPI device path, current code >>> check AllowShortcuts parameter to convert the device path to >>> DisplayOnly text format(shorter text >>> representation) by mistake. >>> It should check DisplayOnly parameter. >>> >>> This commit is to fix this issue. >>> >>> Cc: Ruiyu Ni <[email protected]> >>> Cc: Michael D Kinney <[email protected]> >>> Cc: Liming Gao <[email protected]> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Dandan Bi <[email protected]> >>> --- >>> MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> index cdcdb3623a..97d279eeb2 100644 >>> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( >>> CIDText, >>> UIDStr >>> ); >>> } >>> } else { >>> - if (AllowShortcuts) { >>> + if (DisplayOnly) { >>> // >>> // display only >>> // >>> if (AcpiEx->HID == 0) { >>> UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); >>> -- >>> 2.18.0.windows.1 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
