Jiewen, There are I2C examples for TPM12 in the QuarkPlatformPkg. Would that we a good example too?
Could this new lib class be used for both TPM12 and TPM20 devices? Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > [email protected]] On Behalf Of Yao, Jiewen > Sent: Tuesday, November 13, 2018 2:22 PM > To: Cohen, Eugene <[email protected]>; edk2- > [email protected]; Zhang, Chao B > <[email protected]> > Cc: Bin, Sung-Uk (???) <[email protected]> > Subject: Re: [edk2] [PATCH 1/4] SecurityPkg: enable TPM > components to build for ARM and AARCH64 > > HI Eugene > Thanks to enable SPI TPM chip. > In general, I am OK on this patch series. > > There are some additional work here. > 1) Please split this patch to 2. The TpmIoLib is not > present in at this point of time. We should add it > after TpmIoLib instance is added. > > 2) Since this patch series adds the dependency of > TpmIoLib, please update *all* impacted platform in > EDKII repo and EDKII platform repo. > We need make sure this patch series does not break any > existing platform build. > > 3) I hope, (if possible) you can provide one *real > example* on how to add SPI instance, to demonstrate the > usage and value of this one more layer abstraction. > > Thank you > Yao Jiewen > > > > -----Original Message----- > > From: Cohen, Eugene [mailto:[email protected]] > > Sent: Wednesday, November 14, 2018 6:13 AM > > To: [email protected]; Yao, Jiewen > <[email protected]>; Zhang, > > Chao B <[email protected]> > > Cc: Bin, Sung-Uk (빈성욱) <[email protected]> > > Subject: [PATCH 1/4] SecurityPkg: enable TPM > components to build for ARM > > and AARCH64 > > > > SecurityPkg: enable TPM components to build for ARM > and AARCH64 > > > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > Cc: Chao Zhang <[email protected]> > > Cc: Jiewen Yao <[email protected]> > > Signed-off-by: Eugene Cohen <[email protected]> > > --- > > SecurityPkg/SecurityPkg.dsc | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/SecurityPkg/SecurityPkg.dsc > b/SecurityPkg/SecurityPkg.dsc > > index 68a2953..6fb9ad2 100644 > > --- a/SecurityPkg/SecurityPkg.dsc > > +++ b/SecurityPkg/SecurityPkg.dsc > > @@ -53,6 +53,7 @@ > > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLi > b.inf > > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrin > sic.inf > > + > TpmIoLib|SecurityPkg/Library/TpmIoLibMmio/TpmIoLibMmio. > inf > > > TpmCommLib|SecurityPkg/Library/TpmCommLib/TpmCommLib.in > f > > > > > PlatformSecureLib|SecurityPkg/Library/PlatformSecureLib > Null/PlatformSecu > > reLibNull.inf > > > > > TcgPhysicalPresenceLib|SecurityPkg/Library/DxeTcgPhysic > alPresenceLib/Dxe > > TcgPhysicalPresenceLib.inf > > @@ -199,7 +200,7 @@ > > [Components.IA32, Components.X64, Components.ARM, > > Components.AARCH64] > > > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > > > -[Components.IA32, Components.X64] > > +[Components.IA32, Components.X64 Components.ARM, > > Components.AARCH64] > > # > > > SecurityPkg/UserIdentification/PwdCredentialProviderDxe > /PwdCredentialPr > > oviderDxe.inf > > # > > > SecurityPkg/UserIdentification/UsbCredentialProviderDxe > /UsbCredentialPro > > viderDxe.inf > > > > > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/S > ecureBootConfi > > gDxe.inf > > -- > > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
