Ray Thanks for your constructive comments. I'll improve it in next version.
Thanks, Shenglei > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, November 14, 2018 11:12 AM > To: Zhang, Shenglei <[email protected]>; [email protected] > Cc: Kinney, Michael D <[email protected]>; Gao, Liming > <[email protected]> > Subject: Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant > INFs > > On 11/13/2018 4:35 PM, Shenglei Zhang wrote: > > All INFs of unused Library instances in IntelFrameworkPkg > > are removed as they are not actually used. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 > > > > Cc: Liming Gao <[email protected]> > > Cc: Michael D Kinney <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang <[email protected]> > > --- > > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > index bd5df8c5d9..802a80e3eb 100644 > > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > @@ -63,13 +63,6 @@ > > # generated for it, but the binary will not be put into any firmware > volume. > > # > > > ########################################################## > ######################################### > > -[Components] > > - IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf > > - IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > > - > IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryP > oint.inf > > - > IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.in > f > > - > IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf > > - > > [BuildOptions] > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > > > > Shenglei, > You cannot remove the INF in the separate patch like this. > You should either put this patch in the first patch in your serial, > or combine the DSC change with your library removal. > The goal is the the build won't fail when committing the patches one by one. > > -- > Thanks, > Ray _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
