Hi Shenglei, I would suggest including more description in BZ1304 into the commit message. And please also remove the strings for PcdIdentifyMappingPageTablePtr in MdeModulePkg.uni.
Thanks, Star -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Shenglei Zhang Sent: Thursday, November 15, 2018 3:46 PM To: [email protected] Cc: Ni, Ruiyu <[email protected]>; Zeng, Star <[email protected]> Subject: [edk2] [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr PcdIdentifyMappingPageTablePtr is useless and could be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1304 Cc: Star Zeng <[email protected]> Cc: Jian J Wang <[email protected]> Cc: Ruiyu Ni <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <[email protected]> --- MdeModulePkg/MdeModulePkg.dec | 6 ------ 1 file changed, 6 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 428eeeb670..0abacc1a90 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -2007,12 +2007,6 @@ # @ValidList 0x80000001 | 0x0 gEfiMdeModulePkgTokenSpaceGuid.PcdS3BootScriptTablePrivateSmmDataPtr|0x0|UINT64|0x00030001 - ## This dynamic PCD hold an address to point to the memory of page table. The page table establishes a 1:1 - # Virtual to Physical mapping according to the processor physical address bits. - # @Prompt Identify Mapping Page Table pointer. - # @ValidList 0x80000001 | 0x0 - gEfiMdeModulePkgTokenSpaceGuid.PcdIdentifyMappingPageTablePtr|0x0|UINT64|0x00030002 - ## This dynamic PCD holds the information if there is any test key used by the platform. # @Prompt If there is any test key used by the platform. gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE|BOOLEAN|0x00030003 -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
