Shenglei, I think it would be better to split the patch series in following order: 1. package dec/dsc/uni 2. changes of each module (one patch per module) 3. public header files
Regards, Jian > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, November 19, 2018 3:30 PM > To: [email protected] > Cc: Sun, Zailiang <[email protected]>; Zeng, Star <[email protected]>; > Wang, Jian J <[email protected]>; Ni, Ruiyu <[email protected]>; Gao, > Liming <[email protected]> > Subject: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class > > S3Lib and RecoveryLib have been deprecated since 2009. > There is no code using AcpiS3ResumeOs() interface in > S3Lib and PeiRecoverFirmware() interface in RecoveryLib. > So they can be removed from edk2 repo. > https://bugzilla.tianocore.org/show_bug.cgi?id=1299 > > v2:Remove S3Lib.h and RecoveryLib.h. in MdeModulePkg. > > Cc: Zailiang Sun <[email protected]> > Cc: Star Zeng <[email protected]> > Cc: Jian J Wang <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Cc: Liming Gao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <[email protected]> > Shenglei Zhang (3): > IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib > Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC > MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull > > .../IntelFrameworkModulePkg.dsc | 2 - > .../Library/PeiRecoveryLib/PeiRecoveryLib.c | 50 ------------------ > .../Library/PeiRecoveryLib/PeiRecoveryLib.inf | 50 ------------------ > .../Library/PeiRecoveryLib/PeiRecoveryLib.uni | 23 --------- > .../Library/PeiS3Lib/PeiS3Lib.c | 51 ------------------- > .../Library/PeiS3Lib/PeiS3Lib.inf | 49 ------------------ > .../Library/PeiS3Lib/PeiS3Lib.uni | 23 --------- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 2 - > MdeModulePkg/Include/Library/RecoveryLib.h | 35 ------------- > MdeModulePkg/Include/Library/S3Lib.h | 34 ------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.c | 34 ------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 39 -------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 24 --------- > .../Library/PeiS3LibNull/PeiS3LibNull.c | 35 ------------- > .../Library/PeiS3LibNull/PeiS3LibNull.inf | 40 --------------- > .../Library/PeiS3LibNull/PeiS3LibNull.uni | 24 --------- > MdeModulePkg/MdeModulePkg.dec | 10 ---- > MdeModulePkg/MdeModulePkg.dsc | 2 - > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 -- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 -- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 -- > 21 files changed, 536 deletions(-) > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.c > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.uni > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.c > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.uni > delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h > delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni > > -- > 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
