On 11/19/18 23:29, Jordan Justen wrote: > On 2018-11-19 13:22:27, Andrew Fish wrote:
>> I seem to remember we hit an issue like this a long time ago? Do you >> remember the details? Maybe it was we needed to write the >> TempRamSupport code in assembly? > > It does also creep up there, which is why we also adjust ebp/rbp in > the TemporaryRamMigration function in OVMF. > > In that case, it helps prevent the stack from reverting to the old > stack when TemporaryRamMigration is returning to it's caller. (As > opposed to after it returns, which I think is what is happening now.) Right, in retrospect, I should have been clearer about this (= with myself as well), when pointing out the commit that added the BP massaging to OVMF's temp RAM migration. I just wanted to point out that the BP massaging hadn't always been there in the OVMF code, so it wasn't "part of the original design" or some such. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
