On 11/20/18 11:39, Vijayenthiran Subramaniam wrote: > Add debug messages for failed attempts to write to a variable. > > Cc: Siyuan Fu <[email protected]> > Cc: Jiaxin Wu <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam <[email protected]> > --- > NetworkPkg/IScsiDxe/IScsiMisc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c > index dd0d32dcda16..46760d79a8f3 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -845,6 +845,8 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigOrder); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n", > + __FUNCTION__, Status)); > return Status; > } > > @@ -887,6 +889,8 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigData); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n", > + __FUNCTION__, Status)); > return Status; > } > } >
I'll let Siyuan and Jiaxin decide whether these log messages should be added or not. However, if we do add them, then we should distinguish them better. Right now they look the same. I suggest logging the variable namespace (or "vendor") GUID and the variable name as well. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
