On Tue, 20 Nov 2018 at 15:01, Thomas Abraham <[email protected]> wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > <[email protected]> wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm <[email protected]> > > wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually generated GUIDs in > > > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > > > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, > > > Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c, > > > Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c, > > > Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacer.c, > > > > > > and indeed in the NOR_FLASH_DESCRIPTION struct in > > > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > > > > > > Is this an opportunity for a negative diffstat? > > > > > > > Yes. I was anticipating some discussion on renaming the NOR flash > > blocks, but indeed, we can drop all of the above once the rename > > change is in. > > > > > > > On Mon, Nov 19, 2018 at 07:12:47PM +0000, Leif Lindholm wrote: > > > > On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote: > > > > > The ArmPlatformPkg NOR flash driver has been updated to use device > > > > > paths > > > > > consisting of a fixed GUID and a numeric index rather than a separate > > > > > GUID > > > > > for each flash bank on a given system. This means all explicit device > > > > > path > > > > > references to NOR flash banks have to be brought up to date as well. > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel <[email protected]> > > > > > > > > This looks good to me, but I'd like a comment from Thomas/Nariman. > > > > > > > > With that: > > > > Reviewed-by: Leif Lindholm <[email protected]> > > > > > > Tested this patch and "[PATCH 0/2] ArmPlatformPkg, ArmVirtPkg: > discover NOR flash banks from DTB" patch series on the SGI-575 > platform. Access to NOR flash works fine with bank index as well. > Should GUID's listed in all the instances of NOR_FLASH_DESCRIPTION in > edk2-platforms be removed in this patch? >
Thank you Thomas. I will follow up with a patch that removes all the GUIDs once the EDK2 changes are in. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
