hi Ard, On Fri Nov 23, 2018 at 07:28:19PM +0100, Ard Biesheuvel wrote: > On Thu, 25 Oct 2018 at 09:33, Sughosh Ganu <[email protected]> wrote: > > > > From: Achin Gupta <[email protected]> > > > > This patch adds the definitions, sources, packages and library classes > > needed to compile and link MMU Library suitable for use in S-EL0. > > > > Currently, this is used only during the Standalone MM Core > > initialization and hence defined as MM_CORE_STANDALONE Module. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Sughosh Ganu <[email protected]> > > --- > > ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => > > ArmMmuStandaloneMmCoreLib.inf} | 23 +++++++++----------- > > The code in the previous patch looks fine, but I'd prefer it if we > expose this as a separate library class, not ArmMmuLib > > So please just add a new file, say, > ArmPkg/include/Library/StandaloneMmMmuLib.h, add only the functions > you need, and add it to the LibraryClasses section of ArmPkg.dec as a > new library class. > > Then, you can modify the previous patch to include an updated .inf > that describes it as being an implementation of StandaloneMmMmuLib. > You can then also drop the unimplemented ArmConfigureMmu etc.
Thanks for reviewing the patches. I will incorporate the review comments from both the patches, and post a V4 in the coming week. -sughosh _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
