On Tue, Nov 20, 2018 at 02:37:44PM +0000, Gao, Liming wrote:
> Reviewed-by: Liming Gao <liming....@intel.com>
> 
Hi Liming,

Would you mind to help to push to fix into the git repo?

Thanks,

Gary Lin

> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> > Laszlo Ersek
> > Sent: Tuesday, November 20, 2018 4:52 PM
> > To: Gary Lin <g...@suse.com>; edk2-devel@lists.01.org
> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming 
> > <liming....@intel.com>
> > Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and 
> > Acpi62.h
> > 
> > On 11/20/18 08:03, Gary Lin wrote:
> > > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing
> > > square bracket mistakenly.
> > >
> > > Cc: Michael D Kinney <michael.d.kin...@intel.com>
> > > Cc: Liming Gao <liming....@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Gary Lin <g...@suse.com>
> > > ---
> > >  MdePkg/Include/IndustryStandard/Acpi61.h | 2 +-
> > >  MdePkg/Include/IndustryStandard/Acpi62.h | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Good catch!
> > 
> > Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> > 
> > Thanks
> > Laszlo
> > 
> > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h 
> > > b/MdePkg/Include/IndustryStandard/Acpi61.h
> > > index b2276b7d64d5..c66566e58647 100644
> > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> > > @@ -1400,7 +1400,7 @@ typedef struct {
> > >  #define 
> > > EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE   
> > > { 0x77AB535A, 0x45FC, 0x624B,
> > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }}
> > >  #define 
> > > EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE     
> > > { 0x3D5ABD30, 0x4175, 0x87CE,
> > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }}
> > >  #define 
> > > EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT 
> > > { 0x5CEA02C9, 0x4D07, 0x69D3,
> > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }}
> > > -#define 
> > > EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT   
> > > { 0x08018188, 0x42CD, 0xBB48,
> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]}
> > > +#define 
> > > EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT   
> > > { 0x08018188, 0x42CD, 0xBB48,
> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }}
> > >  typedef struct {
> > >    UINT16                                      Type;
> > >    UINT16                                      Length;
> > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h 
> > > b/MdePkg/Include/IndustryStandard/Acpi62.h
> > > index 730365b521d1..11ce1c16fb91 100644
> > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> > > @@ -1512,7 +1512,7 @@ typedef struct {
> > >  #define 
> > > EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE   
> > > { 0x77AB535A, 0x45FC, 0x624B,
> > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }}
> > >  #define 
> > > EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE     
> > > { 0x3D5ABD30, 0x4175, 0x87CE,
> > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }}
> > >  #define 
> > > EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT 
> > > { 0x5CEA02C9, 0x4D07, 0x69D3,
> > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }}
> > > -#define 
> > > EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT   
> > > { 0x08018188, 0x42CD, 0xBB48,
> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]}
> > > +#define 
> > > EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT   
> > > { 0x08018188, 0x42CD, 0xBB48,
> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }}
> > >  typedef struct {
> > >    UINT16                                      Type;
> > >    UINT16                                      Length;
> > >
> > 
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to