On 11/26/18 18:21, Ard Biesheuvel wrote: > On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek <[email protected]> wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: acpi_test_support >> >> The feature is described in the first patch. Build OvmfPkg and >> ArmVirtPkg platforms with "--pcd PcdAcpiTestSupport=TRUE" to enable it. >> >> Cc: Anthony Perard <[email protected]> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Drew Jones <[email protected]> >> Cc: Igor Mammedov <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Cc: Julien Grall <[email protected]> >> Cc: Philippe Mathieu-Daudé <[email protected]> >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (4): >> OvmfPkg: introduce ACPI Test Support data structure and GUID >> OvmfPkg/AcpiPlatformDxe: list missing lib classes for >> QemuFwCfgAcpiPlatformDxe >> OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiTestSupport() skeletons >> OvmfPkg/AcpiPlatformDxe: fill in ACPI_TEST_SUPPORT at first >> Ready-To-Boot >> > > I'm not crazy about scraping memory, but since this is a test feature, > and since the hypervisor can be trusted to only scrape regions > populated with non-secure DRAM, I can live with it. > > Regarding the GUID: i thought about perhaps using the XOR of two known > GUIDs, but bitwise negation involving a all-ones GUID amounts to the > same thing in the end, so whatever :-) > > Reviewed-by: Ard Biesheuvel <[email protected]>
Thanks :) > >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 10 ++ >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 ++ >> OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c | 119 >> ++++++++++++++++++++ >> OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 24 +++- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 10 ++ >> OvmfPkg/Include/Guid/AcpiTestSupport.h | 67 +++++++++++ >> OvmfPkg/OvmfPkg.dec | 6 + >> 7 files changed, 239 insertions(+), 5 deletions(-) >> create mode 100644 OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c >> create mode 100644 OvmfPkg/Include/Guid/AcpiTestSupport.h >> >> -- >> 2.19.1.3.g30247aa5d201 >> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel

