Yes. I will update it based on your comments, then push the change.
>-----Original Message----- >From: edk2-devel [mailto:[email protected]] On Behalf Of >Laszlo Ersek >Sent: Thursday, November 29, 2018 4:03 AM >To: Philippe Mathieu-Daudé <[email protected]>; Gao, Liming ><[email protected]>; [email protected] >Subject: Re: [edk2] [Patch v2] Maintainers.txt: Add the rule to hand over the >package maintain role > >On 11/28/18 16:13, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 28/11/18 15:03, Liming Gao wrote: >>> In V2, change his to the, and add new maintainers follow up. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Liming Gao <[email protected]> >>> --- >>> Maintainers.txt | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> index 91a4657adc..e102114c34 100644 >>> --- a/Maintainers.txt >>> +++ b/Maintainers.txt >>> @@ -6,7 +6,10 @@ EDK II. >>> >>> In general, you should not privately email the maintainer. You should >>> email the edk2-devel list, and Cc the package maintainers and >>> -reviewers. >>> +reviewers. If the package maintainer wants to hand over the role to >> >> I'd move this to another paragraph, the first one is directed to >> contributors, the second one would be to maintainers. >> >>> +other people, the package maintainer should send the patch to update >>> +Maintainers.txt with new maintainer, and the new maintainer should >>> +follow up with an Acked-by or a Reviewed-by. >> >> I noticed an extra space at the end of the lines you added, which >> resulted in the following errors when applying: >> >> Applying: Maintainers.txt: Add the rule to hand over the package >> maintain role >> .git/rebase-apply/patch:14: trailing whitespace. >> reviewers. If the package maintainer wants to hand over the role to >> .git/rebase-apply/patch:15: trailing whitespace. >> other people, the package maintainer should send the patch to update >> .git/rebase-apply/patch:16: trailing whitespace. >> Maintainers.txt with new maintainer, and the new maintainer should >> error: patch failed: Maintainers.txt:6 >> error: Maintainers.txt: patch does not apply >> >> >> Thanks for adding the maintainership handover clarification, I appreciate :) >> >> With space fixed (same or another paragraphs): >> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > >Good observations! > >My R-b stands, but if Liming decides to fix up the two warts that you >point out (just before pushing), that is, breaking the new sentence to a >new paragraph, and removing trailing whitespace, my R-b stands in that >case too. > >Thanks! >Laszlo >_______________________________________________ >edk2-devel mailing list >[email protected] >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
