On Sat, Oct 20, 2018 at 03:57:39AM +0200, Marcin Wojtas wrote: > Marvell Armada 7k/8k-based platforms may use Pca95xx to extend > amount of the GPIO pins. > > This patch introduces support for PCA95xxx I2C IO expander family, > which is a producer of MARVELL_GPIO_PROTOCOL, by implementing > necessary routines. > > Driver is based on initial work done by Allen Yan <[email protected]>.
Yeah, this is the patch I would also like to add the enums and enum values previously mentioned. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas <[email protected]> > --- > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf | 44 ++ > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h | 74 +++ > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c | 592 > ++++++++++++++++++++ > 3 files changed, 710 insertions(+) > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c > > diff --git a/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf > b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf > new file mode 100644 > index 0000000..3066732 > --- /dev/null > +++ b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf > @@ -0,0 +1,44 @@ > +## @file > +# > +# Copyright (c) 2017, Marvell International Ltd. All rights reserved.<BR> > +# > +# This program and the accompanying materials are licensed and made > available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > +# IMPLIED. > +# > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = MvPca95xxDxe > + FILE_GUID = f0e405eb-8407-43b9-88e6-2f7d70715c72 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = MvPca95xxEntryPoint > + > +[Sources] > + MvPca95xxDxe.c > + MvPca95xxDxe.h > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Silicon/Marvell/Marvell.dec > + > +[LibraryClasses] > + DebugLib > + MemoryAllocationLib > + UefiDriverEntryPoint > + UefiLib > + > +[Protocols] > + gEfiDriverBindingProtocolGuid > + gEfiI2cIoProtocolGuid > + gMarvellBoardDescProtocolGuid > + gMarvellGpioProtocolGuid > + > +[Depex] > + TRUE > diff --git a/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h > b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h > new file mode 100644 > index 0000000..43daee0 > --- /dev/null > +++ b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h > @@ -0,0 +1,74 @@ > +/** > +* > +* Copyright (c) 2018, Marvell International Ltd. All rights reserved. > +* > +* This program and the accompanying materials are licensed and made > available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +* > +**/ > +#ifndef __MV_PCA953X_H__ > +#define __MV_PCA953X_H__ > + > +#include <Library/ArmadaBoardDescLib.h> > +#include <Library/BaseMemoryLib.h> > +#include <Library/DebugLib.h> > +#include <Library/DevicePathLib.h> > +#include <Library/IoLib.h> > +#include <Library/MemoryAllocationLib.h> > +#include <Library/PcdLib.h> > +#include <Library/UefiBootServicesTableLib.h> > +#include <Library/UefiLib.h> > + > +#include <Protocol/BoardDesc.h> > +#include <Protocol/MvGpio.h> > +#include <Protocol/MvI2c.h> > + > +#include <Uefi/UefiBaseType.h> > + > +#define PCA95XX_GPIO_SIGNATURE SIGNATURE_32 ('I', 'O', 'E', 'X') > + > +#ifndef BIT > +#define BIT(nr) (1 << (nr)) > +#endif Eew, now we're adding it again, in yet another file. Same comment as (patch - 2) (I think). Consider trying to add this macro (and a BITPOS one) to Base.h. The alternative is just inlining the shifts. It's basic C and doesn't confuse things. > + > +#define PCA95XX_INPUT_REG 0x0 > +#define PCA95XX_OUTPUT_REG 0x2 > +#define PCA95XX_DIRECTION_REG 0x6 > + > +#define PCA95XX_BANK_SIZE 8 > +#define PCA95XX_OPERATION_COUNT 2 > +#define PCA95XX_OPERATION_LENGTH 1 > + > +typedef enum { > + PCA9505_PIN_COUNT = 40, > + PCA9534_PIN_COUNT = 8, > + PCA9535_PIN_COUNT = 16, > + PCA9536_PIN_COUNT = 4, > + PCA9537_PIN_COUNT = 4, > + PCA9538_PIN_COUNT = 8, > + PCA9539_PIN_COUNT = 16, > + PCA9554_PIN_COUNT = 8, > + PCA9555_PIN_COUNT = 16, > + PCA9556_PIN_COUNT = 16, > + PCA9557_PIN_COUNT = 16, > +} PCA95XX_PIN_COUNT; > + > +typedef enum { > + PCA95XX_READ, > + PCA95XX_WRITE, > +} PCA95XX_OPERATION; So, the only use I see of this is where it is used to in turn select between I2C_FLAG_READ and I2C_FLAG_NORESTART. Can we instead use these directly in MvPca95xxReadRegs/MvPca95xxWriteRegs? > + > +typedef struct { > + MARVELL_GPIO_PROTOCOL GpioProtocol; > + MV_I2C_IO_EXPANDER_DESC *ControllerDesc; > + UINTN ControllerCount; > + UINTN Signature; > + EFI_HANDLE ControllerHandle; > +} PCA95XX; > + > +#endif > diff --git a/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c > b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c > new file mode 100644 > index 0000000..f4a474e > --- /dev/null > +++ b/Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c > @@ -0,0 +1,592 @@ > +/** > +* > +* Copyright (c) 2018, Marvell International Ltd. All rights reserved. > +* > +* This program and the accompanying materials are licensed and made > available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +* > +**/ > + > +#include <Protocol/I2cIo.h> > + > +#include <Pi/PiI2c.h> > + > +#include "MvPca95xxDxe.h" > + > +STATIC PCA95XX *mPca95xxInstance; > + > +STATIC MV_GPIO_DEVICE_PATH mPca95xxDevicePathTemplate = { (Again, static, don't specifically need the Pca95xx prefix. But up to you.) > + { > + { > + HARDWARE_DEVICE_PATH, > + HW_VENDOR_DP, > + { > + (UINT8) (sizeof (VENDOR_DEVICE_PATH) + > + sizeof (MARVELL_GPIO_DRIVER_TYPE)), > + (UINT8) ((sizeof (VENDOR_DEVICE_PATH) + > + sizeof (MARVELL_GPIO_DRIVER_TYPE)) >> 8), > + }, > + }, > + EFI_CALLER_ID_GUID > + }, > + GPIO_DRIVER_TYPE_PCA95XX, > + { > + END_DEVICE_PATH_TYPE, > + END_ENTIRE_DEVICE_PATH_SUBTYPE, > + { > + sizeof(EFI_DEVICE_PATH_PROTOCOL), > + 0 > + } > + } > +}; > + > +STATIC PCA95XX_PIN_COUNT mPca95xxPinCount[PCA95XX_MAX_ID] = { > + PCA9505_PIN_COUNT, > + PCA9534_PIN_COUNT, > + PCA9535_PIN_COUNT, > + PCA9536_PIN_COUNT, > + PCA9537_PIN_COUNT, > + PCA9538_PIN_COUNT, > + PCA9539_PIN_COUNT, > + PCA9554_PIN_COUNT, > + PCA9555_PIN_COUNT, > + PCA9556_PIN_COUNT, > + PCA9557_PIN_COUNT, > +}; > + > +STATIC > +EFI_STATUS > +MvPca95xxValidate ( > + IN UINTN ControllerIndex, > + IN UINTN GpioPin > + ) Same comment as previous patch: add description comment. > +{ > + UINTN ControllerId; > + > + if (ControllerIndex >= mPca95xxInstance->ControllerCount) { > + DEBUG ((DEBUG_ERROR, > + "%a: Invalid GPIO ControllerIndex: %d\n", > + __FUNCTION__, > + ControllerIndex)); > + return EFI_INVALID_PARAMETER; > + } > + > + ControllerId = mPca95xxInstance->ControllerDesc[ControllerIndex].ChipId; > + > + if (GpioPin >= mPca95xxPinCount[ControllerId]) { > + DEBUG ((DEBUG_ERROR, > + "%a: GPIO pin #%d not available in Controller#%d\n", > + __FUNCTION__, > + GpioPin, > + ControllerIndex)); > + return EFI_INVALID_PARAMETER; > + } > + > + return EFI_SUCCESS; > +} > + > +EFI_STATUS > +EFIAPI > +MvPca95xxGetI2c ( > + IN UINTN ControllerIndex, > + IN OUT EFI_I2C_IO_PROTOCOL **I2cIo > + ) > +{ > + UINTN I2cBus, I2cAddress; > + UINTN HandleCount, Index; > + EFI_HANDLE *HandleBuffer; > + EFI_STATUS Status; > + > + I2cBus = mPca95xxInstance->ControllerDesc[ControllerIndex].I2cBus; > + I2cAddress = mPca95xxInstance->ControllerDesc[ControllerIndex].I2cAddress; > + > + /* Locate Handles of all EfiI2cIoProtocol producers */ > + Status = gBS->LocateHandleBuffer (ByProtocol, > + &gEfiI2cIoProtocolGuid, > + NULL, > + &HandleCount, > + &HandleBuffer); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Unable to locate handles\n", __FUNCTION__)); > + return Status; > + } > + > + /* Iterate over all protocol producers and pick one upon DeviceIndex match > */ > + for (Index = 0; Index < HandleCount; Index++) { > + Status = gBS->OpenProtocol (HandleBuffer[Index], > + &gEfiI2cIoProtocolGuid, > + (VOID **)I2cIo, > + gImageHandle, > + NULL, > + EFI_OPEN_PROTOCOL_GET_PROTOCOL); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Unable to open protocol\n", __FUNCTION__)); > + gBS->FreePool (HandleBuffer); > + return Status; > + } > + if ((*I2cIo)->DeviceIndex == I2C_DEVICE_INDEX (I2cBus, I2cAddress)) { > + gBS->FreePool (HandleBuffer); > + return EFI_SUCCESS; > + } > + } > + > + gBS->FreePool (HandleBuffer); > + > + return EFI_NOT_FOUND; > +} > + > +EFI_STATUS > +EFIAPI > +MvPca95xxI2cTransfer ( > + IN EFI_I2C_IO_PROTOCOL *I2cIo, > + IN UINT8 Address, > + IN UINT8 *Buffer, > + IN PCA95XX_OPERATION Operation > + ) > +{ > + EFI_I2C_REQUEST_PACKET *RequestPacket; > + UINTN RequestPacketSize; > + UINT8 AddressBuffer; > + EFI_STATUS Status; > + > + RequestPacketSize = sizeof (UINTN) + > + sizeof (EFI_I2C_OPERATION) * PCA95XX_OPERATION_COUNT; > + RequestPacket = AllocateZeroPool (RequestPacketSize); > + if (RequestPacket == NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > + /* Operations contain address and payload, consecutively. */ > + RequestPacket->OperationCount = PCA95XX_OPERATION_COUNT; > + RequestPacket->Operation[0].LengthInBytes = PCA95XX_OPERATION_LENGTH; > + RequestPacket->Operation[0].Buffer = &AddressBuffer; > + RequestPacket->Operation[0].Buffer[0] = Address & MAX_UINT8; > + RequestPacket->Operation[1].LengthInBytes = PCA95XX_OPERATION_LENGTH; > + RequestPacket->Operation[1].Buffer = Buffer; > + RequestPacket->Operation[1].Flags = (Operation == PCA95XX_READ ? > + I2C_FLAG_READ : I2C_FLAG_NORESTART); > + > + Status = I2cIo->QueueRequest (I2cIo, 0, NULL, RequestPacket, NULL); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: transmission error: 0x%d\n", > + __FUNCTION__, > + Status)); > + } > + > + gBS->FreePool(RequestPacket); > + > + return Status; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxReadRegs ( > + IN EFI_I2C_IO_PROTOCOL *I2cIo, > + IN UINT8 Reg, > + OUT UINT8 *RegVal > + ) > +{ > + return MvPca95xxI2cTransfer (I2cIo, Reg, RegVal, PCA95XX_READ); > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxWriteRegs ( > + IN EFI_I2C_IO_PROTOCOL *I2cIo, > + IN UINTN Reg, > + IN UINT8 RegVal > + ) > +{ > + return MvPca95xxI2cTransfer (I2cIo, Reg, &RegVal, PCA95XX_WRITE); > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxSetOutputValue ( > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + IN BOOLEAN Value > + ) > +{ > + EFI_I2C_IO_PROTOCOL *I2cIo; > + EFI_STATUS Status; > + UINT8 RegVal; > + UINTN Bank; > + > + Status = MvPca95xxGetI2c (ControllerIndex, &I2cIo); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to get I2C protocol\n", __FUNCTION__)); > + return EFI_DEVICE_ERROR; > + } > + > + Bank = GpioPin / PCA95XX_BANK_SIZE; > + > + Status = MvPca95xxReadRegs (I2cIo, PCA95XX_OUTPUT_REG + Bank, &RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to read device register\n", > __FUNCTION__)); > + return EFI_DEVICE_ERROR; > + } > + > + if (Value) { > + RegVal |= BIT (GpioPin % PCA95XX_BANK_SIZE); > + } else { > + RegVal &= ~BIT (GpioPin % PCA95XX_BANK_SIZE); > + } > + > + Status = MvPca95xxWriteRegs (I2cIo, PCA95XX_OUTPUT_REG + Bank, RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to write device register\n", > __FUNCTION__)); > + return EFI_DEVICE_ERROR; > + } > + > + return EFI_SUCCESS; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxSetDirection ( > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + IN MARVELL_GPIO_MODE Direction > + ) > +{ > + EFI_I2C_IO_PROTOCOL *I2cIo; > + EFI_STATUS Status; > + UINT8 RegVal; > + UINTN Bank; > + > + Status = MvPca95xxGetI2c (ControllerIndex, &I2cIo); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to get I2C protocol\n", __FUNCTION__)); > + return Status; > + } > + > + Bank = GpioPin / PCA95XX_BANK_SIZE; > + > + Status = MvPca95xxReadRegs (I2cIo, PCA95XX_DIRECTION_REG + Bank, &RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to read device register\n", > __FUNCTION__)); > + return Status; > + } > + > + if (Direction == GPIO_MODE_INPUT) { > + RegVal |= BIT (GpioPin % PCA95XX_BANK_SIZE); > + } else { > + RegVal &= ~BIT (GpioPin % PCA95XX_BANK_SIZE); > + } > + > + Status = MvPca95xxWriteRegs (I2cIo, PCA95XX_DIRECTION_REG + Bank, RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to write device register\n", > __FUNCTION__)); > + return Status; > + } > + > + return EFI_SUCCESS; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxIsOutput ( > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + OUT MARVELL_GPIO_MODE *Mode > + ) > +{ > + EFI_I2C_IO_PROTOCOL *I2cIo; > + EFI_STATUS Status; > + UINT8 RegVal; > + UINTN Bank; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } Same comment as previous patch: could this be a helper function called from an assert instead? (Applies to identical snippets below too.) > + > + Status = MvPca95xxGetI2c (ControllerIndex, &I2cIo); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to get I2C protocol\n", __FUNCTION__)); > + return Status; > + } > + > + Bank = GpioPin / PCA95XX_BANK_SIZE; > + > + Status = MvPca95xxReadRegs (I2cIo, PCA95XX_DIRECTION_REG + Bank, &RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to read device register\n", > __FUNCTION__)); > + return Status; > + } > + > + *Mode = ((RegVal & BIT (GpioPin % PCA95XX_BANK_SIZE)) ? > + GPIO_MODE_INPUT : GPIO_MODE_OUTPUT); Really same comment as before. If the GPIO_MODE_* values are not meant to reflect the hardware state, we need #defines to do that. And neither way does the ternary make things better. > + > + return EFI_SUCCESS; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxDirectionOutput ( > + IN MARVELL_GPIO_PROTOCOL *This, > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + IN BOOLEAN Value > + ) > +{ > + EFI_STATUS Status; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } > + > + /* Configure output value. */ > + Status = MvPca95xxSetOutputValue (ControllerIndex, GpioPin, Value); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to set ouput value\n", __FUNCTION__)); > + return EFI_DEVICE_ERROR; > + } > + > + /* Configure direction as output. */ > + Status = MvPca95xxSetDirection (ControllerIndex, GpioPin, > GPIO_MODE_OUTPUT); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to set direction\n", __FUNCTION__)); > + } > + > + return Status; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxDirectionInput ( > + IN MARVELL_GPIO_PROTOCOL *This, > + IN UINTN ControllerIndex, > + IN UINTN GpioPin > + ) > +{ > + EFI_STATUS Status; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } > + > + /* Configure direction as input. */ > + Status = MvPca95xxSetDirection (ControllerIndex, GpioPin, GPIO_MODE_INPUT); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to set direction\n", __FUNCTION__)); > + } > + > + return Status; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxGetFunction ( > + IN MARVELL_GPIO_PROTOCOL *This, > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + OUT MARVELL_GPIO_MODE *Mode > + ) > +{ > + EFI_STATUS Status; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } > + > + Status = MvPca95xxIsOutput (ControllerIndex, GpioPin, Mode); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: fail to get pin %d of controller#%d mode\n", > + __FUNCTION__, > + GpioPin, > + ControllerIndex)); > + } > + > + return Status; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxGetValue ( > + IN MARVELL_GPIO_PROTOCOL *This, > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + IN OUT BOOLEAN *Value > + ) > +{ > + EFI_I2C_IO_PROTOCOL *I2cIo; > + EFI_STATUS Status; > + UINT8 RegVal; > + UINTN Bank; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } > + > + Status = MvPca95xxGetI2c (ControllerIndex, &I2cIo); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to get I2C protocol\n", __FUNCTION__)); > + return Status; > + } > + > + Bank = GpioPin / PCA95XX_BANK_SIZE; > + > + Status = MvPca95xxReadRegs (I2cIo, PCA95XX_INPUT_REG + Bank, &RegVal); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to read device register\n", > __FUNCTION__)); > + return Status; > + } > + > + *Value = !!(RegVal & BIT (GpioPin % PCA95XX_BANK_SIZE)); !!! Shift if necessary. / Leif > + > + return EFI_SUCCESS; > +} > + > +STATIC > +EFI_STATUS > +MvPca95xxSetValue ( > + IN MARVELL_GPIO_PROTOCOL *This, > + IN UINTN ControllerIndex, > + IN UINTN GpioPin, > + IN BOOLEAN Value > + ) > +{ > + EFI_STATUS Status; > + > + Status = MvPca95xxValidate (ControllerIndex, GpioPin); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: invalid pin/controller data\n", > + __FUNCTION__, > + GpioPin)); > + return Status; > + } > + > + Status = MvPca95xxSetOutputValue (ControllerIndex, GpioPin, Value); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: fail to set ouput value\n", __FUNCTION__)); > + } > + > + return Status; > +} > + > + > +STATIC > +VOID > +MvPca95xxInitProtocol ( > + IN MARVELL_GPIO_PROTOCOL *GpioProtocol > + ) > +{ > + GpioProtocol->DirectionInput = MvPca95xxDirectionInput; > + GpioProtocol->DirectionOutput = MvPca95xxDirectionOutput; > + GpioProtocol->GetFunction = MvPca95xxGetFunction; > + GpioProtocol->GetValue = MvPca95xxGetValue; > + GpioProtocol->SetValue = MvPca95xxSetValue; > +} > + > +EFI_STATUS > +EFIAPI > +MvPca95xxEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + MARVELL_BOARD_DESC_PROTOCOL *BoardDescProtocol; > + MV_GPIO_DEVICE_PATH *Pca95xxDevicePath; > + MV_BOARD_GPIO_DESC *GpioDesc; > + EFI_STATUS Status; > + > + /* Obtain list of available controllers */ > + Status = gBS->LocateProtocol (&gMarvellBoardDescProtocolGuid, > + NULL, > + (VOID **)&BoardDescProtocol); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: Cannot locate BoardDesc protocol\n", > + __FUNCTION__)); > + return Status; > + } > + > + Status = BoardDescProtocol->BoardDescGpioGet (BoardDescProtocol, > &GpioDesc); > + if (EFI_ERROR (Status) || !GpioDesc->I2cIoExpanderDesc) { > + DEBUG ((DEBUG_ERROR, > + "%a: Cannot get GPIO board desc from BoardDesc protocol\n", > + __FUNCTION__)); > + return Status; > + } else if (!GpioDesc->I2cIoExpanderDesc) { > + /* Silently exit, if the board does not support the controllers */ > + return EFI_SUCCESS; > + } > + > + Pca95xxDevicePath = AllocateCopyPool (sizeof (MV_GPIO_DEVICE_PATH), > + &mPca95xxDevicePathTemplate); > + if (Pca95xxDevicePath == NULL) { > + DEBUG ((DEBUG_ERROR, > + "%a: Fail to allocate Pca95xxDevicePath\n", > + __FUNCTION__)); > + return EFI_OUT_OF_RESOURCES; > + } > + > + mPca95xxInstance = AllocateZeroPool (sizeof (PCA95XX)); > + if (mPca95xxInstance == NULL) { > + DEBUG ((DEBUG_ERROR, > + "%a: Fail to allocate mPca95xxInstance\n", > + __FUNCTION__)); > + goto ErrPca95xxInstanceAlloc; > + } > + > + MvPca95xxInitProtocol (&mPca95xxInstance->GpioProtocol); > + > + mPca95xxInstance->Signature = PCA95XX_GPIO_SIGNATURE; > + mPca95xxInstance->ControllerDesc = GpioDesc->I2cIoExpanderDesc; > + mPca95xxInstance->ControllerCount = GpioDesc->I2cIoExpanderCount; > + > + Status = gBS->InstallMultipleProtocolInterfaces ( > + &(mPca95xxInstance->ControllerHandle), > + &gMarvellGpioProtocolGuid, > + &(mPca95xxInstance->GpioProtocol), > + &gEfiDevicePathProtocolGuid, > + (EFI_DEVICE_PATH_PROTOCOL *)Pca95xxDevicePath, > + NULL); > + if (EFI_ERROR (Status)) { > + goto ErrLocateBoardDesc; > + } > + > + return EFI_SUCCESS; > + > +ErrLocateBoardDesc: > + gBS->FreePool (mPca95xxInstance); > + > +ErrPca95xxInstanceAlloc: > + gBS->FreePool (Pca95xxDevicePath); > + > + return Status; > +} > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
