On Thu, Dec 06, 2018 at 01:12:02PM +0100, Ard Biesheuvel wrote: > After fixing the iasl issue yesterday, I got a bit carried away and ended > up rewriting most of the ACPI table generation logic for Styx. So this > applies on top of the patches I sent out yesterday. > > Patch #1 merges the DXE driver and the library, that are split in two for > no good reason. > > Patch #2 simplifies the MADT generation code.
I would be lying if I said I'd properly reviewed this series, but superficially it looks good, and I trust you to have tested it properly. So: Reviewed-by: Leif Lindholm <[email protected]> > Ard Biesheuvel (2): > Silicon/AMD/Styx: merge ACPI table drivers > Silicon/Styx/AcpiPlatformDxe: simplify MADT generation logic > > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 1 - > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 - > .../Overdrive1000Board/Overdrive1000Board.dsc | 1 - > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 1 + > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 1 + > .../Overdrive1000Board/Overdrive1000Board.fdf | 1 + > Silicon/AMD/Styx/AcpiTables/AcpiTables.inf | 85 ----- > .../AcpiPlatformDxe/AcpiPlatformDxe.inf | 34 +- > .../AcpiPlatformDxe/AcpiPlatform.h} | 11 +- > Silicon/AMD/Styx/AcpiTables/Madt.c | 318 ------------------ > .../Drivers/AcpiPlatformDxe/AcpiPlatform.c | 155 +++++---- > .../AcpiPlatformDxe/Csrt.aslc} | 13 +- > .../AcpiPlatformDxe/Dbg2.aslc} | 12 +- > .../AcpiPlatformDxe/Fadt.aslc} | 11 +- > .../AcpiPlatformDxe/Gtdt.aslc} | 20 +- > .../AcpiPlatformDxe/Iort.aslc} | 19 +- > .../Styx/Drivers/AcpiPlatformDxe/Madt.aslc | 117 +++++++ > .../AcpiPlatformDxe/Mcfg.aslc} | 13 +- > .../AcpiPlatformDxe/Pptt.aslc} | 10 +- > .../AcpiPlatformDxe/Spcr.aslc} | 12 +- > 20 files changed, 264 insertions(+), 572 deletions(-) > delete mode 100644 Silicon/AMD/Styx/AcpiTables/AcpiTables.inf > rename Silicon/AMD/Styx/{Common/AmdStyxAcpiLib.h => > Drivers/AcpiPlatformDxe/AcpiPlatform.h} (81%) > delete mode 100644 Silicon/AMD/Styx/AcpiTables/Madt.c > rename Silicon/AMD/Styx/{AcpiTables/Csrt.c => > Drivers/AcpiPlatformDxe/Csrt.aslc} (93%) > rename Silicon/AMD/Styx/{AcpiTables/Dbg2.c => > Drivers/AcpiPlatformDxe/Dbg2.aslc} (95%) > rename Silicon/AMD/Styx/{AcpiTables/Fadt.c => > Drivers/AcpiPlatformDxe/Fadt.aslc} (96%) > rename Silicon/AMD/Styx/{AcpiTables/Gtdt.c => > Drivers/AcpiPlatformDxe/Gtdt.aslc} (92%) > rename Silicon/AMD/Styx/{AcpiTables/Iort.c => > Drivers/AcpiPlatformDxe/Iort.aslc} (95%) > create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Madt.aslc > rename Silicon/AMD/Styx/{AcpiTables/Mcfg.c => > Drivers/AcpiPlatformDxe/Mcfg.aslc} (86%) > rename Silicon/AMD/Styx/{AcpiTables/Pptt.c => > Drivers/AcpiPlatformDxe/Pptt.aslc} (97%) > rename Silicon/AMD/Styx/{AcpiTables/Spcr.c => > Drivers/AcpiPlatformDxe/Spcr.aslc} (90%) > > -- > 2.19.2 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
