OK. I'll get it fixed. -----Original Message----- From: Ard Biesheuvel [mailto:[email protected]] Sent: Tuesday, December 11, 2018 9:49 PM To: Feng, Bob C <[email protected]> Cc: Gao, Liming <[email protected]>; Andrew Fish <[email protected]>; Leif Lindholm <[email protected]>; [email protected] Subject: Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses
On Tue, 11 Dec 2018 at 14:38, Feng, Bob C <[email protected]> wrote: > > Hi Ard, > > Would you please try this format? While I'll check this issue anyway. > > [PcdsDynamic] > gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0})}|UINT8[6]|0x000d0001 > gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0})}|UINT8[6]|0x000d0002 > > and this in my .dsc file > > [PcdsDynamicDefault.common] > gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0x2,0xA1,0xA2,0xA3,0xA4,0xA5})} > > gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0x2,0xB1,0xB2,0xB3,0xB4,0xB5} > )} > Processing meta-data ....... build.py... : error F015: From DEC Default Value {CODE({0})}:28:9: error: expected expression before ‘{’ token From DEC Default Value {CODE({0})}:87:9: error: expected expression before ‘{’ token > > Thanks, > Bob > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, December 11, 2018 9:15 PM > To: Ard Biesheuvel <[email protected]>; Feng, Bob C > <[email protected]> > Cc: Andrew Fish <[email protected]>; Leif Lindholm > <[email protected]>; [email protected] > Subject: RE: [edk2] [PATCH edk2-platforms] > Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses > > > BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1390 is submit for it. Bob > will fix it. > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:[email protected]] > > Sent: Tuesday, December 11, 2018 3:54 PM > > To: Gao, Liming <[email protected]> > > Cc: Andrew Fish <[email protected]>; Leif Lindholm > > <[email protected]>; [email protected] > > Subject: Re: [edk2] [PATCH edk2-platforms] > > Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses > > > > On Tue, 11 Dec 2018 at 01:53, Gao, Liming <[email protected]> wrote: > > > > > > If PCD is related to one structure in DEC/DSC, it can be refer as > > > structure pointer in C source code. Here is wiki for its usage: > > https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage > > > > > > > OK so I now have this in my .dec file > > > > [PcdsDynamic] > > gAmdStyxTokenSpaceGuid.PcdEthMacA|{0}|UINT8[6]|0x000d0001 > > gAmdStyxTokenSpaceGuid.PcdEthMacB|{0}|UINT8[6]|0x000d0002 > > > > and this in my .dsc file > > > > [PcdsDynamicDefault.common] > > gAmdStyxTokenSpaceGuid.PcdEthMacA|{0x2,0xA1,0xA2,0xA3,0xA4,0xA5} > > gAmdStyxTokenSpaceGuid.PcdEthMacB|{0x2,0xB1,0xB2,0xB3,0xB4,0xB5} > > > > and the build errors out immediately with: > > > > Processing meta-data ....... > > > > build.py... > > : error F015: > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:15:20: > > error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value’ > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:41:16: > > error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value’ > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:74:20: > > error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value’ > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:100:16: > > error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value’ > > undeclared (first use in this function) _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
