Reviewed-by: Jian J Wang <jian.j.w...@intel.com>

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, December 07, 2018 7:23 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Kinney, Michael D
> <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; Wang,
> Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Leif
> Lindholm <leif.lindh...@linaro.org>; Laszlo Ersek <ler...@redhat.com>; Eric
> Auger <eric.au...@redhat.com>; Andrew Jones <drjo...@redhat.com>;
> Philippe Mathieu-Daude <phi...@redhat.com>
> Subject: [RFC PATCH 2/7] MdeModulePkg/Dxe/Gcd: disregard memory above
> MAX_ALLOC_ADDRESS
> 
> Update the GCD memory map initialization code so it disregards
> memory that is not addressable by the CPU at boot time. This
> only affects the first memory descriptor that is added, other
> memory descriptors are permitted that describe memory ranges
> that may be accessible to the CPU itself only when executing
> under the OS.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
> ---
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> index a76d2db73c46..504e14a74e1d 100644
> --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> @@ -2284,7 +2284,7 @@ CoreInitializeMemoryServices (
>      // region that is big enough to initialize the DXE core.  Always skip 
> the PHIT
> Resource HOB.
>      // The max address must be within the physically addressible range for 
> the
> processor.
>      //
> -    HighAddress = MAX_ADDRESS;
> +    HighAddress = MAX_ALLOC_ADDRESS;
>      for (Hob.Raw = *HobStart; !END_OF_HOB_LIST(Hob); Hob.Raw =
> GET_NEXT_HOB(Hob)) {
>        //
>        // Skip the Resource Descriptor HOB that contains the PHIT
> @@ -2300,7 +2300,7 @@ CoreInitializeMemoryServices (
>        }
> 
>        //
> -      // Skip Resource Descriptor HOBs that do not describe tested system
> memory below MAX_ADDRESS
> +      // Skip Resource Descriptor HOBs that do not describe tested system
> memory below MAX_ALLOC_ADDRESS
>        //
>        ResourceHob = Hob.ResourceDescriptor;
>        if (ResourceHob->ResourceType != EFI_RESOURCE_SYSTEM_MEMORY) {
> @@ -2309,14 +2309,14 @@ CoreInitializeMemoryServices (
>        if ((ResourceHob->ResourceAttribute & MEMORY_ATTRIBUTE_MASK) !=
> TESTED_MEMORY_ATTRIBUTES) {
>          continue;
>        }
> -      if ((ResourceHob->PhysicalStart + ResourceHob->ResourceLength) >
> (EFI_PHYSICAL_ADDRESS)MAX_ADDRESS) {
> +      if ((ResourceHob->PhysicalStart + ResourceHob->ResourceLength) >
> (EFI_PHYSICAL_ADDRESS)MAX_ALLOC_ADDRESS) {
>          continue;
>        }
> 
>        //
>        // Skip Resource Descriptor HOBs that are below a previously found
> Resource Descriptor HOB
>        //
> -      if (HighAddress != (EFI_PHYSICAL_ADDRESS)MAX_ADDRESS &&
> ResourceHob->PhysicalStart <= HighAddress) {
> +      if (HighAddress != (EFI_PHYSICAL_ADDRESS)MAX_ALLOC_ADDRESS &&
> ResourceHob->PhysicalStart <= HighAddress) {
>          continue;
>        }
> 
> --
> 2.19.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to