On Wed, Dec 12, 2018 at 11:33:05AM +0100, Ard Biesheuvel wrote: > Building with Clang 3.5 for ARM may result in build breakage, due to the > fact that it may emit non-adjacent movw/movt instructions pairs which > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > work around a related issue in the relocatable PrePi in ArmVirtPkg, but > we need to disable movw/movt entirely to really address this issue. > > So first, fix some breakage that results from building with -mlong-calls > in the optimized BaseMemoryLib code (#1) > > Patch #2 switches to -mkernel, which disables movw/movt generation (and > enabled -mlong-calls as a side effect) > > Patch #3 removes the now redundant, and incompatible command line > overrides for the relocatable PrePi.
For 1,3/3: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > > Ard Biesheuvel (3): > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > change > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > BaseTools/Conf/tools_def.template | 2 +- > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > 7 files changed, 9 insertions(+), 11 deletions(-) > > -- > 2.19.2 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
