Hi Leif Thanks for your constructive guide. I 'll improve my later patches.
Thanks, Shenglei > -----Original Message----- > From: Leif Lindholm [mailto:[email protected]] > Sent: Thursday, December 13, 2018 6:52 PM > To: Zhang, Shenglei <[email protected]> > Cc: [email protected]; Kinney, Michael D > <[email protected]>; Gao, Liming <[email protected]> > Subject: Re: [edk2] [PATCH 0/2] Add two public functions > > Please let the subject line give some sort of hint of what is being > done, and to what. "Add two functions" is not substantially more > descriptive than "add 572 characters". > > In this case, your're moving previously internal string helper functions > to BaseLib. > > On Thu, Dec 13, 2018 at 04:34:37PM +0800, Shenglei Zhang wrote: > > Add two public functions,CharToUpper and AsciiToUpper,and > > remove the same functional functions,InternalCharToUpper > > and InternalBaseLibAsciiToUpper. > > > > Cc: Michael D Kinney <[email protected]> > > Cc: Liming Gao <[email protected]> > > Cc: Bob Feng <[email protected]> > > Cc: Yonghong Zhu <[email protected]> > > Shenglei Zhang (2): > > MdePkg/BaseLib: Add two public functions > > BaseTools/Common: Remove InternalCharToUpper > > > > BaseTools/Source/C/Common/CommonLib.c | 16 ++------- > > BaseTools/Source/C/Common/CommonLib.h | 4 --- > > MdePkg/Include/Library/BaseLib.h | 40 +++++++++++++++++++++ > > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ----------------------- > > MdePkg/Library/BaseLib/SafeString.c | 8 ++--- > > MdePkg/Library/BaseLib/String.c | 35 ++++--------------- > > 6 files changed, 53 insertions(+), 92 deletions(-) > > > > -- > > 2.18.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
