On 12/14/18 01:47, Ye, Ting wrote: > Thanks all for the info and follow up. Laszlo, please let me know if there is > additional step you think I need follow, thanks.
In the future, please let's make sure that the maintainer that is about to give up the role posts the maintenance change *in advance*. It's not a rule I invented or even campaigned for, but it's there, and so we should attempt to follow it. No more comments on this particular update. Thanks, Laszlo > From: Long, Qin > Sent: Friday, December 14, 2018 2:30 AM > To: Gao, Liming <[email protected]>; Laszlo Ersek <[email protected]>; Ye, > Ting <[email protected]> > Cc: [email protected] > Subject: RE: [edk2] [PATCH] Maintainers.txt: Change package maintainer and > reviewer of CryptoPkg. > > Confirmed by Long, Qin <[email protected]<mailto:[email protected]>> > > (And sorry for this rule breaking caused by me. I didn't notice this updates.) > > Best Regards & Thanks, > LONG, Qin > > From: Gao, Liming > Sent: Thursday, December 13, 2018 9:15 PM > To: Laszlo Ersek <[email protected]<mailto:[email protected]>>; Ye, Ting > <[email protected]<mailto:[email protected]>>; Long, Qin > <[email protected]<mailto:[email protected]>> > Cc: [email protected]<mailto:[email protected]> > Subject: RE: [edk2] [PATCH] Maintainers.txt: Change package maintainer and > reviewer of CryptoPkg. > > Laszlo: > Yes. Long, Qin should send this patch. Because Long, Qin changes to another > work group for a while, he doesn't work on edk2 project. Ting directly sends > the patch to remove his name. I just include Long, Qin, and let him confirm > this change. > > Thanks > Liming >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, December 13, 2018 6:38 PM >> To: Ye, Ting <[email protected]<mailto:[email protected]>> >> Cc: [email protected]<mailto:[email protected]> >> Subject: Re: [edk2] [PATCH] Maintainers.txt: Change package maintainer and >> reviewer of CryptoPkg. >> >> Hi Ting, >> >> On 12/13/18 08:41, tye1 wrote: >>> Cc: Gang Wei <[email protected]<mailto:[email protected]>> >>> Cc: Jian Wang <[email protected]<mailto:[email protected]>> >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ting Ye <[email protected]<mailto:[email protected]>> >>> --- >>> Maintainers.txt | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> index 001d8ba010..d5cb305da9 100644 >>> --- a/Maintainers.txt >>> +++ b/Maintainers.txt >>> @@ -102,8 +102,9 @@ S: Maintained >>> >>> CryptoPkg >>> W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg >>> -M: Qin Long <[email protected]<mailto:[email protected]>> >>> M: Ting Ye <[email protected]<mailto:[email protected]>> >>> +R: Gang Wei <[email protected]<mailto:[email protected]>> >>> +R: Jian Wang <[email protected]<mailto:[email protected]>> >>> >>> DynamicTablesPkg >>> W: https://github.com/tianocore/tianocore.github.io/wiki/DynamicTablesPkg >>> >> >> This patch does not conform to the rule that we added lately; please see >> commit 9ebef6c0a7d3 ("Maintainers.txt: Add the rule to hand over the >> package maintain role", 2018-11-29). >> >> In other words, the patch should be sent out by Qin Long. Even though >> you co-maintain CryptoPkg with Qin Long, you shouldn't be able to >> deprive Qin Long from the role. >> >> Thanks, >> Laszlo >> _______________________________________________ >> edk2-devel mailing list >> [email protected]<mailto:[email protected]> >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
