Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Friday, December 14, 2018 1:54 AM > To: Zhang, Shenglei <[email protected]>; [email protected] > Cc: Carsey, Jaben <[email protected]>; Ni, Ruiyu <[email protected]> > Subject: Re: [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove > the unused function CharToUpper > Importance: High > > On 12/14/18 08:56, Shenglei Zhang wrote: > > CharToUpper is an unused function, so it will be removed. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1399 > > > > v2:Update the title. > > > > Cc: Laszlo Ersek <[email protected]> > > Cc: Jaben Carsey <[email protected]> > > Cc: Ruiyu Ni <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang <[email protected]> > > --- > > .../UefiShellDebug1CommandsLib.c | 28 ------------------- > > 1 file changed, 28 deletions(-) > > > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > > index bd4dfa98f7..480441b0f9 100644 > > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.c > > @@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor ( > > return (EFI_SUCCESS); > > } > > > > -/** > > - Convert a Unicode character to upper case only if > > - it maps to a valid small-case ASCII character. > > - > > - This internal function only deal with Unicode character > > - which maps to a valid small-case ASCII character, i.e. > > - L'a' to L'z'. For other Unicode character, the input character > > - is returned directly. > > - > > - @param Char The character to convert. > > - > > - @retval LowerCharacter If the Char is with range L'a' to L'z'. > > - @retval Unchanged Otherwise. > > - > > - > > - //Stolen from MdePkg Baselib > > -**/ > > -CHAR16 > > -CharToUpper ( > > - IN CHAR16 Char > > - ) > > -{ > > - if (Char >= L'a' && Char <= L'z') { > > - return (CHAR16) (Char - (L'a' - L'A')); > > - } > > - > > - return Char; > > -} > > > > /** > > Function returns a system configuration table that is stored in the > > > > Reviewed-by: Laszlo Ersek <[email protected]> > > Thanks! > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
